Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix checkout to next branch #326

Merged

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented May 4, 2021

Description

Changes proposed in this pull request:

As in title. Fix checkout to next branch in wc-release and bump workflows. Checkout to next when in release_tag will contain next substring.

@magicmatatjahu magicmatatjahu added the area/ci Related to all activities around Continuous Integration label May 4, 2021
@magicmatatjahu magicmatatjahu requested a review from derberg May 4, 2021 10:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you use contains function in many places. I suggest doing something like:

- name: initial step to set variable that will be used in all next steps
   id: release
   run: echo "::set-output name=isNext::$(contains(github.event.release.tag_name, 'next'))"
- name: now I can just use this variable in if to evaluate if next or not
   if: steps.release.outputs.isNext == 'true'

not a blocker here, can be a followup, especially that you need to also do it in .github. Up to you as I guess you are not 100% sure if this will even work as expected

@magicmatatjahu
Copy link
Member Author

@derberg Thanks! First I thought about variable, but I'm afraid if the syntax will work.

@derberg
Copy link
Member

derberg commented May 4, 2021

@magicmatatjahu magicmatatjahu merged commit ca8694b into asyncapi:master May 4, 2021
@magicmatatjahu magicmatatjahu deleted the master-branches/fix-workflows branch May 4, 2021 10:44
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.23.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Related to all activities around Continuous Integration released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants