refactor: remove unnecessary code #309
Conversation
magicmatatjahu
added
the
area/library
|
Kudos, SonarCloud Quality Gate passed!
|
| "prepare": "npm run build:prod", | ||
| "prepack": "cp ../README.md ./README.md && cp ../LICENSE ./LICENSE", | ||
| "prepare": "npm run build:dev", | ||
| "prepack": "npm run build:prod && cp ../README.md ./README.md && cp ../LICENSE ./LICENSE", | ||
| "postpack": "rm -rf ./README.md && rm -rf ./LICENSE", |
There was a problem hiding this comment.
what is this for? why do we remove readme and license
There was a problem hiding this comment.
License and Readme are moved from root of project to library before publish, so by this library hasn't Readme in git, but we have it in npm https://www.npmjs.com/package/@asyncapi/react-component?activeTab=dependencies
After postpack we remove it (but these are copies).
There was a problem hiding this comment.
perfect, thanks for explanation, I wish there was package.yml so we could have comments for future :(
There was a problem hiding this comment.
🤦🏼 Due to this https://github.com/asyncapi/asyncapi-react/blob/master/package.json#L20 from this commit a00fcc9 currently we haven't License and Readme on npm...
There was a problem hiding this comment.
I will fix it the PR with bumping dependencies for "old" component.
|
🎉 This PR is included in version 0.21.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Changes proposed in this pull request:
umdbundles from@asyncapi/react-component/bundles/umd/...to@asyncapi/react-component/browserto improve DX.umdbundles - Readme.md and in NextJS tutorial.Related issue(s)
Part of asyncapi/shape-up-process#83