fix: informative Stubs when document is invalid #1068
Conversation
catosaurusrex2003
requested review from
magicmatatjahu,
derberg,
fmvilas and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
catosaurusrex2003
changed the title
|
The line in diagnostics being returned by the parser is not accurate when there are @derberg should we include the line number in the errors ? example: below error should be on line 12, but it is showing on line 7 cuz it ignored the multi-lined string of |
|
I upgraded the package |
|
|
/rtm |
This reverts commit 31c2a86.
|
@catosaurusrex2003, i noticed something after merging this PR that the error line seem not to be acccurate for some of the errors just as seen below. It should be line 3 not line 4 🤔 |
|
Wanna fix this in a follow-up PR? |
|
🎉 This PR is included in version 2.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@AceTheCreator I would love to work on this. But I cant seem to reproduce this issue again. i tried the below on https://asyncapi.github.io/asyncapi-react/ could it be you are running it locally without reinstalling the |
|
Yea, that was the reason 😄. Everything looks good 🚀 Thanks for the fix 👍🏾 |
Description
Diagnostics with severity 0 are displayed as errors.
Before
(Invalid document 👇 with syntax error)
After
(Invalid document 👇 with syntax error)
(document with spec specific errors 👇)
Related Issue
#1048
#874