Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support missing fields/objects from spec 2.0.0 #63

Closed
10 of 11 tasks
magicmatatjahu opened this issue Sep 11, 2019 · 16 comments
Closed
10 of 11 tasks

Support missing fields/objects from spec 2.0.0 #63

magicmatatjahu opened this issue Sep 11, 2019 · 16 comments
Labels
area/community Related to all activities that are done for community area/documentation Related to all activities around documentation area/library Related to all activities around Library package enhancement New feature or request

Comments

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Sep 11, 2019

Description

At the moment we support a main part of spec in rendering, but there are also parts that we don't, like bindings, properties from schema (min, max, type etc) - https://github.com/asyncapi/asyncapi/blob/master/versions/next/asyncapi.md#properties, externalDocs, tags, correlationID etc.

AC:

  • support all missing fields/objects in rendering. With any question about design/styling, please contact with @fmvilas or our designers.

List:

Updated list (4 May 2021):

@magicmatatjahu magicmatatjahu added enhancement New feature or request area/library Related to all activities around Library package area/documentation Related to all activities around documentation area/community Related to all activities that are done for community labels Sep 11, 2019
@magicmatatjahu magicmatatjahu added this to the Backlog_Wookiee milestone Sep 11, 2019
@fmvilas
Copy link
Member

fmvilas commented Sep 11, 2019

FYI, protocolInfo = bindings. Bindings is the new name.

@magicmatatjahu magicmatatjahu changed the title Support missing fields/objects from spec 2.0.0-rc2 Support missing fields/objects from spec 2.0.0 Sep 11, 2019
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Mar 11, 2020
@hesyar
Copy link
Contributor

hesyar commented Apr 6, 2020

We need this feature too. Will this be implemented in the near future?

@GreenRover
Copy link
Contributor

+1

@derberg
Copy link
Member

derberg commented Apr 13, 2020

@hesyar this component was donated by the team behind this project https://kyma-project.io/ and they are main maintainers atm. Afaik, they are super busy atm at least until May. Would it be something you could contribute? AsyncAPI core team is more focused on generator and parser to have 1.0 release for both

@hesyar
Copy link
Contributor

hesyar commented Apr 13, 2020

Hi @derberg thanks for your reply. For what I can do now is to update the parser version. Furthermore I'll try to contribute more if I find any time. Thanks, I'll let you know as soon as I've the new version.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jul 14, 2020
@derberg derberg removed the stale label Jul 14, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 30 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Nov 14, 2020
@derberg derberg removed the stale label Nov 16, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Jan 16, 2021
@derberg
Copy link
Member

derberg commented Jan 18, 2021

@magicmatatjahu I thought properties from schema (min, max, type etc) - https://github.com/asyncapi/asyncapi/blob/master/versions/next/asyncapi.md#properties is already supported?

@magicmatatjahu
Copy link
Member Author

@derberg Yes, I updated the issue description with list

@derberg derberg removed the stale label Jan 18, 2021
@derberg
Copy link
Member

derberg commented Jan 18, 2021

awesome, we need to add correlationID and also update the readme then

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 60 days if no further activity occurs. To unstale this issue, add a comment with detailed explanation.
Thank you for your contributions ❤️

@github-actions github-actions bot added the stale label Mar 20, 2021
@derberg derberg removed the stale label Mar 22, 2021
@magicmatatjahu magicmatatjahu removed this from the Backlog_Wookiee milestone Apr 16, 2021
@magicmatatjahu
Copy link
Member Author

In 1.0.0-next.1:

  • supporting almost everything from JSON Schema draft-07 except dependencies and true/false schemas (due to bug in parser Handling schema true and false parser-js#232)
  • supporting from AsyncAPI 2.0.0 everything except:
    • id
    • operationId
    • externalDocs in operation
    • discriminator in AsyncAPI JSON Schema

@magicmatatjahu
Copy link
Member Author

In 1.0.0-next.9:

Discriminator will be handled under https://github.com/asyncapi/html-template/issues/68 issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/community Related to all activities that are done for community area/documentation Related to all activities around documentation area/library Related to all activities around Library package enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants