Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tags & headers section from traits #179

Closed
ITman1 opened this issue Nov 12, 2020 · 3 comments
Closed

Missing tags & headers section from traits #179

ITman1 opened this issue Nov 12, 2020 · 3 comments

Comments

@ITman1
Copy link

ITman1 commented Nov 12, 2020

Description

I tried to integrate this component into my project and I hit on two things which I miss and on https://playground.asyncapi.io/ they work. That is why I would to ask if there is any plan to support them also in this React component? Thank you.

Attachments

image

@derberg
Copy link
Member

derberg commented Nov 13, 2020

@ITman1 Hey. So you mention 2 different features here:

  • tags are not supported but definitely should be, there is a list of not supported props Support missing fields/objects from spec 2.0.0 #63 Would be great to get some help here
  • traits work properly, at least to me. Traits are resolved by the parser that we use in the react component. So it is not about headers in traits, they work the same if they are in traits or not. I checked and looks like headers are properly supported 👇
    Screenshot 2020-11-13 at 11 50 56

@ITman1
Copy link
Author

ITman1 commented Nov 13, 2020

@derberg Sorry, my bad, I have found a reason why it did not work for me. I tried to fix missing tag feature by putting [KAFKA] suffix into channel name which resulted into invalid schema. This caused that traits stopped to work - even for the messages.

Today I also found that required fields are not visualised anyhow. We could maybe track it somewhere. Anyway thank you for prompt answer and closing this issue.

@ITman1 ITman1 closed this as completed Nov 13, 2020
@derberg
Copy link
Member

derberg commented Nov 14, 2020

@ITman1 no worries mate, it is always better to ask. If you find some bugs or have more questions just create issues or join our slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants