Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed Unnecessary Comment #41

Merged
merged 2 commits into from
Oct 4, 2023
Merged

chore: removed Unnecessary Comment #41

merged 2 commits into from
Oct 4, 2023

Conversation

ShashwatPS
Copy link
Contributor

Description :

  • Removed the commented out code in library/src/components/layouts/CircleLayout.tsx.

Related issue(s) :

@ShashwatPS
Update CircleLayout.tsx
65c08b6 
Removed the commented out Code.
@jonaslagoni jonaslagoni changed the title fix: removed Unnecessary Comment chore: removed Unnecessary Comment Oct 4, 2023
jonaslagoni
jonaslagoni approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to chore as we dont need to release anything 🙂

Nice @ShashwatPS 👍

@jonaslagoni
Copy link
Member

/rtm

@ShashwatPS
Copy link
Contributor Author

Thanks for fixing the title and sorry for the inconvenience.

@ShashwatPS ShashwatPS closed this Oct 4, 2023
@jonaslagoni jonaslagoni reopened this Oct 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ShashwatPS ShashwatPS requested a review from jonaslagoni October 4, 2023 12:31
jonaslagoni
jonaslagoni approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonaslagoni
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 1790f9f into asyncapi:master Oct 4, 2023
17 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @ShashwatPS for code

@allcontributors allcontributors bot mentioned this pull request Oct 4, 2023
Merged
@allcontributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @ShashwatPS! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShashwatPS @jonaslagoni @asyncapi-bot