fix: evaluated GitHub actions workflow files #268
Conversation
mhmohona
requested review from
derberg,
quetzalliwrites,
fmvilas,
KhudaDad414 and
asyncapi-bot-eve
as code owners
mhmohona
changed the title
mhmohona
changed the title
mhmohona
changed the title
|
I have a concern on it. After running the actionlit for this repo it was the output - For first 2 errors, when I tested the scripts in https://rhysd.github.io/actionlint/, it didnt catch them. If i address them, then both from actionlit online site and IDE I get error. Should I address 1st 2 errors then? Or probably its a bug. :3 |
There was a problem hiding this comment.
Amazing initiative, thanks!!!
Can you refactor to not download linter binary but use a dedicated github action
https://github.com/raven-actions/actionlint
?
|
@mhmohona do you plan to continue with this one? |
|
@mhmohona do you plan to continue with this one or should we ask community to continue? |
| with: | ||
| script: | | ||
| const sendEmail = require('./.github/workflows/scripts/mailchimp/index.js'); | ||
| sendEmail('${{github.event.comment.html_url}}', '${{github.event.discussion.title}}'); | ||
| sendEmail('${{github.event.comment.html_url}}', process.env.DISCUSSION_TITLE); |
There was a problem hiding this comment.
do you modify it because the linter complained?
I wonder then why github.event.comment.html_url did not have to be refactored as well 🤔
| @@ -14,59 +14,5 @@ jobs: | |||
| - name: Checkout Code | |||
| uses: actions/checkout@v2 | |||
There was a problem hiding this comment.
| uses: actions/checkout@v2 | |
| uses: actions/checkout@v4 |
| - name: Check workflow files | ||
| uses: raven-actions/actionlint@v1 |
There was a problem hiding this comment.
please do not use directly v1 when action is not official, from github, but commit id (in your other PR you do it, so you have example there)
Description
Related issue(s)
#257