Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add lighthouse ci for tracking website performance #142

Closed
wants to merge 1 commit into from

Conversation

HarshCasper
Copy link
Contributor

Description

  • Add a lighthouse-ci-test.yml to track web performance
  • Add a lighthouserc.json to define the Lighthouse configuration.

Related issue(s)

See also asyncapi/website#89

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@KhudaDad414
Copy link
Member

Hey @HarshCasper, thanks for the contribution. I think this workflow belongs to the website repo. Is there a reason why we should have it here instead on the website repo itself?

@HarshCasper
Copy link
Contributor Author

Hi @KhudaDad414 — Thanks for your comment! Quoting @magicmatatjahu from this issue (asyncapi/server-api#50):

However, testing is done by this workflow https://github.com/asyncapi/server-api/blob/master/.github/workflows/if-nodejs-pr-testing.yml but we cannot update it, because the source for this workflow is located here https://github.com/asyncapi/.github/blob/master/.github/workflows/if-nodejs-pr-testing.yml Even if you change something on this repo (in the source of that workflow) in future it will be overwritten by asyncapi-bot.

I suppose it would stand true here as well. All of the workflows specific to every project under the AsyncAPI is hosted here. It would make sense if we have the LightHouse CI workflow hosted here as well. I would love to get @derberg thoughts as well on this!

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is ❤️

before we make review please move it to website repo. This workflow is super custom, only for the website so should not land in .github repo. Whatever lands here in .github is then replicated to all other repositories, and we do not want it in this case.

@HarshCasper
Copy link
Contributor Author

I will close it then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants