-
Notifications
You must be signed in to change notification settings - Fork 16
fix: work correctly on pre-parsed AsyncAPI docs when given as Input #103
fix: work correctly on pre-parsed AsyncAPI docs when given as Input #103
Conversation
Pull Request Test Coverage Report for Build 2315283440
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 Want to add tests to ensure it always works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should add at least two simple tests, one with parsed AsyncAPI and another one with document saved string/JSON object.
shall I replace the current tests with pre-parsed AsyncAPI docs or add tests for pre-parsed AsyncAPI docs separately. |
Depends on what you want to support, if it is both inputs, you would need two tests 🙂 |
Co-authored-by: Maciej Urbańczyk <[email protected]>
Co-authored-by: Maciej Urbańczyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@jonaslagoni @derberg shall we merge this one? |
@arjungarg07 I didn't notice that. You should fix the errors from sonarcloud. |
@magicmatatjahu sorry, but I can't see any sonarcloud errors. Can you please point them out. |
@arjungarg07 as code owner, remember you can always merge it your self ones all required checks passes 🙂 Use |
@jonaslagoni since the issue was created by you, I was waiting for a review from your side as well😅 |
Ahh okay, yea, keep pinging me then 😆 Cause once I see @magicmatatjahu reviewed it I did not expect I needed to spend time on it as well 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…rg07/app-relations-discovery into fix/pre-parsed-doc-input
b0c634b
@derberg one approving review required before merging. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🎉 This PR is included in version 0.6.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Related issue(s)
#74