Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_by #379

Closed
wants to merge 9 commits into from
Closed

Add max_by #379

wants to merge 9 commits into from

Commits on Oct 23, 2019

  1. Introduce the notion of direction for the min_by func

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    117a065 View commit details
    Browse the repository at this point in the history

  2. Rename to MinMax

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    ef44801 View commit details
    Browse the repository at this point in the history

  3. Rename content to value as its no longer min/max

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    05143e0 View commit details
    Browse the repository at this point in the history

  4. Use the direction for existing minimize

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    6868501 View commit details
    Browse the repository at this point in the history

  5. Add maximizing function

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    df03a7f View commit details
    Browse the repository at this point in the history

  6. Don't expose Direction, just expose to fns

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    da23e73 View commit details
    Browse the repository at this point in the history

  7. Shrink the match arms to make the intent clearer

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    89519f0 View commit details
    Browse the repository at this point in the history

  8. Only have one construtor parametrized over all values

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    3d69a5c View commit details
    Browse the repository at this point in the history

  9. Run fmt

    @felipesere
    felipesere committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    b7c79aa View commit details
    Browse the repository at this point in the history