Enable tests on CI #357
Merged
Enable tests on CI #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests seem broken (because they were merged without being tested on CI). |
ghost
reviewed
Oct 16, 2019
tests/buf_writer.rs
Outdated
| @@ -47,6 +47,7 @@ fn test_buffered_writer() { | |||
| }) | |||
| } | |||
|
|
|||
| #[ignore] | |||
There was a problem hiding this comment.
This assertion is failed:
Line 57 in ca80ca9
Error:
---- test_buffered_writer_inner_into_inner_does_not_flush stdout ----
thread 'test_buffered_writer_inner_into_inner_does_not_flush' panicked at 'assertion failed: `(left == right)`
left: `[0, 1]`,
right: `[]`', tests/buf_writer.rs:57:9
I think this is because #315 changed the behavior of lnto_inner: https://github.com/async-rs/async-std/pull/315/files#diff-a2b217372e599101d2b0f1dbab63ee2eR205
taiki-e
force-pushed
the
tests
branch
2 times, most recently
from
f54f132 to
cf1bcc6
Compare
ghost
approved these changes
Oct 16, 2019
Done.
I don't have merge right... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #286 (comment), if cargo test contains --doc arguments, only doc test is executed.