fix: Export directives to federation SDL so they can be composed. #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the format CI failure is unrelated to these changes |
… example of this feature.
dbanty
force-pushed
the
fix-federated-directives
branch
from
c70358e to
cefa68d
Compare
|
Ah, it was an earlier commit to examples that broke formatting. I made a PR for that too async-graphql/examples#67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added example of this feature in async-graphql/examples#66
Also also updated the reported federation version to 2.1 so that
@deferis available by default with Apollo tooling. The only change to 2.1 is@composeDirectivewhich isn't applicable to this project since it isn't used with executable directives, only custom schema ones.