-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 644 #645
Issue 644 #645
Conversation
let's also use a more self-explanatory title in additional to the issue number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks fine, some small glitches
List is invariant so we have to update the function return type annotation a bit: python/mypy#3351
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
- Coverage 80.77% 80.77% -0.01%
==========================================
Files 240 240
Lines 17153 17152 -1
==========================================
- Hits 13856 13855 -1
Misses 3297 3297
Continue to review full report at Codecov.
|
This PR fixes issue #644.
Description of changes
Change the type_id in
data_list
representation of DataStore from integer to string of the fully qualified type name.Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
Passed all original tests of DataStore.