Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 644 #645

Merged
merged 18 commits into from
Feb 20, 2022
Merged

Issue 644 #645

merged 18 commits into from
Feb 20, 2022

Conversation

qinzzz
Copy link
Collaborator

@qinzzz qinzzz commented Feb 18, 2022

This PR fixes issue #644.

Description of changes

Change the type_id in data_list representation of DataStore from integer to string of the fully qualified type name.

Possible influences of this PR.

Describe what are the possible side-effects of the code change.

Test Conducted

Passed all original tests of DataStore.

@hunterhector
Copy link
Member

let's also use a more self-explanatory title in additional to the issue number

Copy link
Member

@hunterhector hunterhector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks fine, some small glitches

forte/processors/base/batch_processor.py Outdated Show resolved Hide resolved
forte/data/data_store.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 20, 2022

Codecov Report

Merging #645 (97876e4) into master (10cbdc7) will decrease coverage by 0.00%.
The diff coverage is 79.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
- Coverage   80.77%   80.77%   -0.01%     
==========================================
  Files         240      240              
  Lines       17153    17152       -1     
==========================================
- Hits        13856    13855       -1     
  Misses       3297     3297              
Impacted Files Coverage Δ
forte/data/ontology/core.py 84.06% <ø> (ø)
forte/processors/ir/bert_based_query_creator.py 86.20% <ø> (ø)
forte/processors/nlp/ner_predictor.py 17.12% <ø> (ø)
forte/data/data_store.py 73.49% <66.66%> (-0.32%) ⬇️
forte/data/base_store.py 70.73% <100.00%> (ø)
forte/data/converter/converter.py 95.78% <100.00%> (ø)
forte/data/data_pack.py 87.16% <100.00%> (ø)
forte/data/types.py 100.00% <100.00%> (ø)
tests/forte/data/data_store_test.py 98.07% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10cbdc7...97876e4. Read the comment docs.

@hunterhector hunterhector merged commit 6c6e371 into asyml:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants