-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legends to show Disease and Chemical as Annotation #54
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 84.17% 85.04% +0.87%
==========================================
Files 9 10 +1
Lines 512 602 +90
==========================================
+ Hits 431 512 +81
- Misses 81 90 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -0,0 +1,57 @@ | |||
''' | |||
this file defines search functions for searching data in elasticsearch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason why we aren't using LastUtteranceSearcher
processor to search through elastic search and return the links for documents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is what I think:
We create a search engine by streamlit, and I think it is a simple and easy way to wrap the search into method and when the user clicks "Query", this method is called directly to query and then displayed the results on the interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel its just redundant if we already have this functionality implemented in our processors and we still write another method to achieve the same thing, but it could be simpler and hence could be used for just the demo. You should confirm this with hector once. @hunterhector
This PR fixes #53.
Description of changes
This PR makes the following 4 main changes: