Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the shouldExpand behavior to set the layout at the time the tab is added #46

Merged
merged 1 commit into from
Dec 13, 2013

Conversation

dmapr
Copy link

@dmapr dmapr commented Nov 22, 2013

On Android versions prior to 4.3 I observed a behavior in my app where the shouldExpand had no effect other than dropping the tabPadding. By moving the application of the expandedTabLayout instead of defaultTabLayout to the tab adding code as opposed to onMeasure code I was able to resolve the issue. The downside is that #42 is incompatible with this change as the weight can't be assigned beforehand.

See below for the illustration of the problem. With the fix both 4.0.3 and 4.3 behavior is the same for expansion.

pagerslidingtabstrip-4 0 3
pagerslidingtabstrip-4 3

…ab is added rather than in onMeasure to solve some problems observed on Android < 4.3
@JaydipRadadiya
Copy link

astuetz ! Thank you so much..
Working Perfectly in my project

@dmapr dmapr deleted the jive-pr branch March 17, 2017 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants