use astropy modeling units in fit_lines #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* units in models were added in astropy 4.0 and specutils now requires astropy 4.1+
* no longer need to strip and re-add units or have a custom QuantityModel
This reverts commit 6e9148d.
* if model in astropy does not support units, then use previous specutils implementation of stripping units, re-adding units, and returning a QuantityModel,
9 tasks
rosteen
approved these changes
Nov 2, 2021
| window_indices = np.nonzero((spectrum.spectral_axis >= center-window) & | ||
| (spectrum.spectral_axis < center+window)) | ||
| window_indices = np.nonzero((dispersion >= center-window) & | ||
| (dispersion < center+window)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes use of the new support for units within astropy modeling (introduced in astropy 4.0, specutils already requires 4.1+) and in doing so removes the need for significant code that handled stripping and re-adding units internally.
Edit: apparently not all models in astropy support being fitted with units, so perhaps we can't entirely get rid of the internal stripping/re-adding for all cases.