Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SDSS-V SpectrumList format ambiguity, mwmVisit BOSS load fail #1185

Merged
merged 15 commits into from
Nov 1, 2024

Commits on Oct 11, 2024

  1. fix: mwmVisit BOSS HDU default loader fail

    - no longer checks for "date_obs"; calculate that yourself
    - also adds "sdss_id" to metadata now
    rileythai committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b6851a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. fix: SDSS-V SpectrumList loader ambiguity + add: BOSS-only mwm test c…

    …ases
    
    - added new test cases for BOSS-only mwmVisit and mwmStar files
    - added new checks to SpectrumList mwmVisit/mwmStar test to check verified filetype is correct
    - forced override on default SpectrumList loaders -- now SpectrumList is no longer ambiguous and doesn't require a format specification
      - relevant areas in tests are updated accordingly
    - added print warnings to when HDU is not specified on Spectrum1D loaders for files with multiple spectra.
    - ensured tests now remove tempfiles with os.remove
      - arguably, this could work better with tmpfile, but i don't know how tests are deployed on the server-side
    rileythai committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    51e8a2e View commit details
    Browse the repository at this point in the history
  2. add: changelog -> CHANGES.rst

    - three points outlining changes listed in PR as per astropy#1185
    rileythai committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    4bee136 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. fix: HDU unspecified print message

    Co-authored-by: Brian Cherinka <[email protected]>
    rileythai and havok2063 authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b70c393 View commit details
    Browse the repository at this point in the history
  2. feat: condense loaders into only SpectrumList of 1D flux

    - all loaders now only load for a single datatype, avoiding prior knowledge of SDSS datatypes
    - updated to only load as SpectrumList
    - updated to load all visits in mwmVisit files as individual Spectrum1D objects in the SpectrumList
    - relevant tests removed
    - relevant import __all__ adjusted
    rileythai committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    62747c4 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'mwmvisit-boss-fix' of github.com:rileythai/specutils-sd…

    …ss-loaders into mwmvisit-boss-fix
    rileythai committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8df1f77 View commit details
    Browse the repository at this point in the history
  4. chore: changelog update

    - describes changes shown previously
    rileythai committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bafede9 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. revert: readd all Spectrum1D loaders and tests

    revert back to 4bee136
    rileythai committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    122b368 View commit details
    Browse the repository at this point in the history
  2. feat: visit specification on mwmVisit load

    - readded print -> warnings conversion
    - can specify the visit to load on mwmVisit load.
    - added relevant tests for the new mwmVisit case
    rileythai committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    0c5fe8f View commit details
    Browse the repository at this point in the history
  3. Merge branch 'mwmvisit-boss-fix' of github.com:rileythai/specutils-sd…

    …ss-loaders into mwmvisit-boss-fix
    rileythai committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    32534a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. revert: completely rollback to initial case

    - no longer unpacks nD spectrum in all cases for mwm
    - will still unpack flux from 2D to 1D in the event its single visit or coadd
    rileythai committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    ca4d8c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Configuration menu
    Copy the full SHA
    62152c0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'mwmvisit-boss-fix' of github.com:rileythai/specutils-sd…

    …ss-loaders into mwmvisit-boss-fix
    rileythai committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    65b5709 View commit details
    Browse the repository at this point in the history
  3. fix: test cases

    - fixed flux array length check so that the 2D mwm visits are checked properly
    rileythai committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    9960f98 View commit details
    Browse the repository at this point in the history
  4. fix: split test cases for user warning + remove useless warning

    - removed HDU is empty warning on mwm SpecList, not really worth a warning
    - moved test cases which are designed to throw exceptions into their own test function
    rileythai committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    87fa13f View commit details
    Browse the repository at this point in the history