-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SDSS-V SpectrumList format ambiguity, mwmVisit BOSS load fail #1185
Commits on Oct 11, 2024
-
fix: mwmVisit BOSS HDU default loader fail
- no longer checks for "date_obs"; calculate that yourself - also adds "sdss_id" to metadata now
Configuration menu - View commit details
-
Copy full SHA for b6851a6 - Browse repository at this point
Copy the full SHA b6851a6View commit details
Commits on Oct 12, 2024
-
fix: SDSS-V SpectrumList loader ambiguity + add: BOSS-only mwm test c…
…ases - added new test cases for BOSS-only mwmVisit and mwmStar files - added new checks to SpectrumList mwmVisit/mwmStar test to check verified filetype is correct - forced override on default SpectrumList loaders -- now SpectrumList is no longer ambiguous and doesn't require a format specification - relevant areas in tests are updated accordingly - added print warnings to when HDU is not specified on Spectrum1D loaders for files with multiple spectra. - ensured tests now remove tempfiles with os.remove - arguably, this could work better with tmpfile, but i don't know how tests are deployed on the server-side
Configuration menu - View commit details
-
Copy full SHA for 51e8a2e - Browse repository at this point
Copy the full SHA 51e8a2eView commit details -
- three points outlining changes listed in PR as per astropy#1185
Configuration menu - View commit details
-
Copy full SHA for 4bee136 - Browse repository at this point
Copy the full SHA 4bee136View commit details
Commits on Oct 16, 2024
-
fix: HDU unspecified print message
Co-authored-by: Brian Cherinka <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b70c393 - Browse repository at this point
Copy the full SHA b70c393View commit details -
feat: condense loaders into only SpectrumList of 1D flux
- all loaders now only load for a single datatype, avoiding prior knowledge of SDSS datatypes - updated to only load as SpectrumList - updated to load all visits in mwmVisit files as individual Spectrum1D objects in the SpectrumList - relevant tests removed - relevant import __all__ adjusted
Configuration menu - View commit details
-
Copy full SHA for 62747c4 - Browse repository at this point
Copy the full SHA 62747c4View commit details -
Merge branch 'mwmvisit-boss-fix' of github.com:rileythai/specutils-sd…
…ss-loaders into mwmvisit-boss-fix
Configuration menu - View commit details
-
Copy full SHA for 8df1f77 - Browse repository at this point
Copy the full SHA 8df1f77View commit details -
Configuration menu - View commit details
-
Copy full SHA for bafede9 - Browse repository at this point
Copy the full SHA bafede9View commit details
Commits on Oct 18, 2024
-
revert: readd all Spectrum1D loaders and tests
revert back to 4bee136
Configuration menu - View commit details
-
Copy full SHA for 122b368 - Browse repository at this point
Copy the full SHA 122b368View commit details -
feat: visit specification on mwmVisit load
- readded print -> warnings conversion - can specify the visit to load on mwmVisit load. - added relevant tests for the new mwmVisit case
Configuration menu - View commit details
-
Copy full SHA for 0c5fe8f - Browse repository at this point
Copy the full SHA 0c5fe8fView commit details -
Merge branch 'mwmvisit-boss-fix' of github.com:rileythai/specutils-sd…
…ss-loaders into mwmvisit-boss-fix
Configuration menu - View commit details
-
Copy full SHA for 32534a2 - Browse repository at this point
Copy the full SHA 32534a2View commit details
Commits on Oct 19, 2024
-
revert: completely rollback to initial case
- no longer unpacks nD spectrum in all cases for mwm - will still unpack flux from 2D to 1D in the event its single visit or coadd
Configuration menu - View commit details
-
Copy full SHA for ca4d8c3 - Browse repository at this point
Copy the full SHA ca4d8c3View commit details
Commits on Oct 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62152c0 - Browse repository at this point
Copy the full SHA 62152c0View commit details -
Merge branch 'mwmvisit-boss-fix' of github.com:rileythai/specutils-sd…
…ss-loaders into mwmvisit-boss-fix
Configuration menu - View commit details
-
Copy full SHA for 65b5709 - Browse repository at this point
Copy the full SHA 65b5709View commit details -
- fixed flux array length check so that the 2D mwm visits are checked properly
Configuration menu - View commit details
-
Copy full SHA for 9960f98 - Browse repository at this point
Copy the full SHA 9960f98View commit details -
fix: split test cases for user warning + remove useless warning
- removed HDU is empty warning on mwm SpecList, not really worth a warning - moved test cases which are designed to throw exceptions into their own test function
Configuration menu - View commit details
-
Copy full SHA for 87fa13f - Browse repository at this point
Copy the full SHA 87fa13fView commit details