add debug logging to all catch-all exceptions

astropy · Feb 1, 2019 · b3bf16e · b3bf16e
1 parent aef9a82
commit b3bf16e
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 7 deletions.
diff --git a/specutils/io/default_loaders/hst_cos.py b/specutils/io/default_loaders/hst_cos.py
@@ -21,8 +21,9 @@ def cos_identify(origin, *args, **kwargs):
                 return True
             else:
                 return False
-    except:
-        logging.exception("Tried to read this as HST/COS file, but could not.")
+    except Exception as e:
+        logging.debug("Tried to read this as HST/COS file, but could not.")
+        logging.debug(e, exc_info=True)
         return False
 
 @data_loader(label="HST/COS", identifier=cos_identify, extensions=['FITS', 'FIT', 'fits', 'fit'])

diff --git a/specutils/io/default_loaders/hst_stis.py b/specutils/io/default_loaders/hst_stis.py
@@ -21,8 +21,9 @@ def stis_identify(origin, *args, **kwargs):
                 return True
             else:
                 return False
-    except:
-        logging.exception("Tried to read this as HST/COS file, but could not.")
+    except Exception as e:
+        logging.debug("Tried to read this as HST/COS file, but could not.")
+        logging.debug(e, exc_info=True)
         return False
 
 

diff --git a/specutils/io/default_loaders/muscles_sed.py b/specutils/io/default_loaders/muscles_sed.py
@@ -27,7 +27,9 @@ def identify_muscles_sed(origin, *args, **kwargs):
                      fits.open(args[0])[0].header['PROPOSID'] == 13650
                     )
         return ismuscles
-    except:
+    except Exception as e:
+        logging.debug("Tried to read as MUSCLES SED file, but could not.")
+        logging.debug(e, exc_info=True)
         return False
 
 @data_loader("muscles-sed", identifier=identify_muscles_sed,

diff --git a/specutils/io/default_loaders/tabular_fits.py b/specutils/io/default_loaders/tabular_fits.py
@@ -31,7 +31,9 @@ def identify_tabular_fits(origin, *args, **kwargs):
                      isinstance(fits.open(args[0])[1], fits.BinTableHDU)
                      )
         return istabfits
-    except:
+    except Exception as e:
+        logging.debug("Tried to read as tabular fits file, but could not.")
+        logging.debug(e, exc_info=True)
         return False
 
 

diff --git a/specutils/io/default_loaders/wcs_fits.py b/specutils/io/default_loaders/wcs_fits.py
@@ -24,7 +24,9 @@ def identify_wcs1d_fits(origin, *args, **kwargs):
                      'CTYPE1' in fits.getheader(args[0])
                      )
         return iswcsfits
-    except:
+    except Exception as e:
+        logging.debug("Tried to read as fits WCS file, but could not.")
+        logging.debug(e, exc_info=True)
         return False