Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 1D wavelength calibration classes #162

Merged
merged 31 commits into from
Apr 12, 2023
Merged

Implement 1D wavelength calibration classes #162

merged 31 commits into from
Apr 12, 2023

Commits on Jan 18, 2023

  1. Working on line pixel refinement

    @rosteen
    rosteen committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    d58f652 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Testing/debugging CalibrationLine, starting on WavelengthCalibration

    @rosteen
    rosteen committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    1f3483a View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Working on model fitting and construction of resulting GWCS

    @rosteen
    rosteen committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    c54aed7 View commit details
    Browse the repository at this point in the history

  2. Working through bugs/testing

    @rosteen
    rosteen committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    5eb4aaa View commit details
    Browse the repository at this point in the history

  3. Working initial implementation

    @rosteen
    rosteen committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    baa706c View commit details
    Browse the repository at this point in the history

  4. Codestyle

    @rosteen
    rosteen committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    02ed67e View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Match order of pixel/wavelength between CalibrationLine and Wavelengt… 

    …hCalibration1D, add tests
    @rosteen
    rosteen committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    1df8621 View commit details
    Browse the repository at this point in the history

  2. Fix codestyle in test

    @rosteen
    rosteen committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    eb5feea View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Adding tests for CalibrationLine

    @rosteen
    rosteen committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    6ea98e4 View commit details
    Browse the repository at this point in the history

  2. Fix codestlye

    @rosteen
    rosteen committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    af4a523 View commit details
    Browse the repository at this point in the history

  3. Increase atol for gaussian center

    @rosteen
    rosteen committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    568fd09 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Remove autoidentify for now, add Polynomial1D test

    @rosteen
    rosteen committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    be35c09 View commit details
    Browse the repository at this point in the history

  2. Add cache clearing, avoid AstropyUserWarning

    @rosteen
    rosteen committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    f3b1b9f View commit details
    Browse the repository at this point in the history

  3. Add input_spectrum property and clear cache on setting it

    @rosteen
    rosteen committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    8117864 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Add default range if method is set but not range, remove check for un… 

    …implemented method
    @rosteen
    rosteen committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    8f1535b View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Also clear cache when updating lines or model

    @rosteen
    rosteen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    22e2d68 View commit details
    Browse the repository at this point in the history

  2. Move fitter default to wcs call

    @rosteen
    rosteen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4a508e3 View commit details
    Browse the repository at this point in the history

  3. Keep storing fitter as None

    @rosteen
    rosteen committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    a8ca23f View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Add docs, improve importing of new classes

    @rosteen
    rosteen committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    1941a26 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Remove CalibrationLine, move to astropy tables internallyt

    @rosteen
    rosteen committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    829dc5c View commit details
    Browse the repository at this point in the history

  2. Codestyle

    @rosteen
    rosteen committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    c3ba30d View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Kyle Conroy <[email protected]>
    @rosteen @kecnry
    rosteen and kecnry authored Apr 7, 2023
    Configuration menu
    Copy the full SHA
    62c8025 View commit details
    Browse the repository at this point in the history

  2. Remove speactral_units arg, add docstring for fitter arg

    @rosteen
    rosteen committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    12a8661 View commit details
    Browse the repository at this point in the history

  3. Update documentation, add NotImplementedError for catalog input

    @rosteen
    rosteen committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    5063b5e View commit details
    Browse the repository at this point in the history

  4. Reverse sort frequencies

    @rosteen
    rosteen committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    b6a92f8 View commit details
    Browse the repository at this point in the history

  5. Codestyle

    @rosteen
    rosteen committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    1aa62c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Increase test coverage

    @rosteen
    rosteen committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    7f31b61 View commit details
    Browse the repository at this point in the history

  2. Fix tests and bugs found by tests

    @rosteen
    rosteen committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    45939a9 View commit details
    Browse the repository at this point in the history

  3. Codestyle

    @rosteen
    rosteen committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    f92bac5 View commit details
    Browse the repository at this point in the history

  4. Add QTable to catalog options

    @rosteen
    rosteen committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    d573219 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Finish addressing review comments

    @rosteen
    rosteen committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    82170a5 View commit details
    Browse the repository at this point in the history