-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background.bkg_spectrum and sub_spectrum #143
Conversation
Codecov Report
@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 70.57% 71.12% +0.54%
==========================================
Files 9 9
Lines 605 613 +8
==========================================
+ Hits 427 436 +9
+ Misses 178 177 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are logical additions that line up well with bkg_image
. The core looks good to me, so the following comments are on peripheral issues.
Co-authored-by: ojustino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the only outstanding comment is on a private function, it shouldn't prevent a merge if others are ready for one.
(Note to self that this will cause some merge conflicts with #144)
* was misplaced under the previous 1.1.0 release
This PR implements methods to expose the background (and background-subtracted) spectrum from a Background object.