Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background.bkg_spectrum and sub_spectrum #143

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Sep 28, 2022

This PR implements methods to expose the background (and background-subtracted) spectrum from a Background object.

bg = Background.two_sided(image, trace, separation, width)
bg.bkg_spectrum()
bg.sub_spectrum()

@kecnry kecnry marked this pull request as ready for review September 28, 2022 14:04
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #143 (cade209) into main (78e68b7) will increase coverage by 0.54%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
+ Coverage   70.57%   71.12%   +0.54%     
==========================================
  Files           9        9              
  Lines         605      613       +8     
==========================================
+ Hits          427      436       +9     
+ Misses        178      177       -1     
Impacted Files Coverage Δ
specreduce/background.py 87.67% <100.00%> (+3.29%) ⬆️
specreduce/extract.py 89.23% <100.00%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ojustino ojustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are logical additions that line up well with bkg_image. The core looks good to me, so the following comments are on peripheral issues.

specreduce/background.py Outdated Show resolved Hide resolved
specreduce/background.py Outdated Show resolved Hide resolved
specreduce/extract.py Show resolved Hide resolved
Copy link
Contributor

@ojustino ojustino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the only outstanding comment is on a private function, it shouldn't prevent a merge if others are ready for one.

(Note to self that this will cause some merge conflicts with #144)

@kecnry kecnry merged commit 44d3533 into astropy:main Oct 3, 2022
@kecnry kecnry deleted the bg-spectrum branch October 3, 2022 18:39
kecnry added a commit to kecnry/specreduce that referenced this pull request Oct 4, 2022
* was misplaced under the previous 1.1.0 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants