-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.12 testing #403
Python 3.12 testing #403
Conversation
Codecov Report
@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 25 25
Lines 891 891
=======================================
Hits 834 834
Misses 57 57 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ha, so it turns out the issue isn't building the local copy of reproject, but the testing dep |
So I think the best way round this is to not test with sunpy on Python 3.12, until a release of reproject has been done with Python 3.12 to PyPI. I can't see another good way to avoid the sunpy test dependency trying to pull in a version of reproject from PyPI that is incompatible with Python 3.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
No description provided.