Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug that caused reprojected dask arrays to not be computable due to a temporary directory being removed #390

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

astrofrog
Copy link
Member

@keflavich - this is a fix for the issue we were seeing. Note that we need to keep the temporary directory around for a while because the user might call compute multiple times etc. So I think we might just need to document how to clean up the temporary directory once it is no longer needed.

@keflavich
Copy link
Contributor

Yes, that will certainly be important. Will it naturally get cleaned up if the cube is deleted? It's not obvious to me that it will.

@astrofrog
Copy link
Member Author

@keflavich - this won't get cleaned up automatically except by the operating system using the regular temporary directory cleanup. So this is not a good solution for spectral-cube. However, it's a fix that at least allows smaller cubes to be reprojected, so I'll go ahead and merge and work on a better solution.

@astrofrog astrofrog merged commit 7f3fe0e into astropy:main Sep 14, 2023
12 of 13 checks passed
@astrofrog astrofrog added the bug label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants