-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: remove the usage of the astropy TestRunner #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice to not have to keep a duplicate conftest.py
any longer. Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 81.68% 81.70% +0.01%
==========================================
Files 69 69
Lines 7089 7093 +4
==========================================
+ Hits 5791 5795 +4
Misses 1298 1298 ☔ View full report in Codecov by Sentry. |
Yeap, those got me confused several times, and there are still some inconsistencies. E.g Larry kept the one in the photutils directory, though the one there seems to have the comments that it was required by the TestRunner and not by pytest. Anyway, this layout seems to work both locally with |
Not sure if "online tests" job failures are related. Also, now you don't need the test runner, you can even move all the tests out of package dir if you want. |
Test failures are unrelated, something is off at CADC atm.
No, I really don't want to move them out and really don't want to move to a |
It works on my side, and if you think that this won't affect the users, getting it in a bugfix release would be welcome PS: these browser-running python instances are awesome for workshops, maybe I can show you at the IVOA if you're interested? We already have a cds jupyterlite instance with working astroquery examples here (see notebook 1, even if it needs way more text). It'd be nice to also be able to showcase pyvo PPS: thank you so much for the quick PR !! |
Yes, I don't expect any user level issues as we haven't advertized it, and anyway, that usage is underused in the wider astropy ecosystem, too. PS: I'm very much interested in your browser experience! I'm familiar with the interactive documentation approaches that are happening in the wider scientific python ecosystem, and we are thinking about interactive tutorials, too, but none of those got to the point of applicability on the astroquery/pyvo/navo levels. |
MAINT: remove the usage of the astropy TestRunner
This is to address #604 as well as the upstream plans of actually deprecating the TestRunner.
We haven't really advertised the
pyvo.test()
functionality anywhere, so I would be OK with including this in a bugfix release in the coming few weeks, if that is something you would find helpful @ManonMarchand