Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix error message for SSA diameter #581

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 1, 2024

Trivial fix

@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2024

@andamian - there are still some cadc issues that the SIA2 tests run into. Expected or news?

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hu. I had long forgotten that SSA's SIZE actually is a diameter rather than a radius (admittedly, the name is a bit of a giveaway, but still). Anyway, let's go with this fix.

@msdemlei msdemlei merged commit 32d3a7c into astropy:main Aug 1, 2024
9 of 10 checks passed
@bsipocz
Copy link
Member Author

bsipocz commented Aug 1, 2024

Yes, I wondered and poked around why we don't call it "size", I suppose it's on purpose to be clear it's a diameter and not a radius.

@bsipocz bsipocz deleted the MAINT_error_message_typo branch August 1, 2024 12:33
bsipocz pushed a commit that referenced this pull request Oct 14, 2024
MAINT: Fix error message for SSA diameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants