Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix Python 3.12 comaptibility and add it to CI #488

Merged
merged 4 commits into from
Oct 8, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Sep 22, 2023

No description provided.

@bsipocz bsipocz added this to the v1.4.3 milestone Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #488 (e1e5c30) into main (75bcb73) will increase coverage by 0.06%.
Report is 14 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   80.01%   80.07%   +0.06%     
==========================================
  Files          52       52              
  Lines        6039     6059      +20     
==========================================
+ Hits         4832     4852      +20     
  Misses       1207     1207              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz
Copy link
Member Author

bsipocz commented Sep 22, 2023

Actually, all the fixes are for deprecation warnings and all work out of the box, so I don't think we need the changelog after all.

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update @bsipocz . LGTM

@tomdonaldson tomdonaldson merged commit ba81520 into astropy:main Oct 8, 2023
@bsipocz bsipocz deleted the CI_add_py312 branch October 20, 2023 17:45
@bsipocz bsipocz modified the milestones: v1.4.3, v1.5 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants