-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul registry interface #289
Commits on Jun 1, 2022
-
Adding a basic framework to build RegTAP constraints, and the first A…
…uthor and Freetext constraints
Configuration menu - View commit details
-
Copy full SHA for 511d9cc - Browse repository at this point
Copy the full SHA 511d9ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8077a3a - Browse repository at this point
Copy the full SHA 8077a3aView commit details -
Column selection and grouping for datasearch.
This introduces expected_columns in existing regtap.RegistryResource, which I now intend to re-use (and evolve) for the data discovery, too. It will now declare what columns are required from the queries itself (where I suspect we'll have to be a bit niftier if we want more advanced categories of data we get in the initial discovery query).
Configuration menu - View commit details
-
Copy full SHA for e095876 - Browse repository at this point
Copy the full SHA e095876View commit details -
Configuration menu - View commit details
-
Copy full SHA for c95758b - Browse repository at this point
Copy the full SHA c95758bView commit details -
Adding a Servicetype constraint.
Also, I've found that we can keep the existing registry.search interface (and adding another interface isn't worth the extra effort). Hence, I've renamed the previous datasearch to rtcons ("RegTAP constraints"). This breaks regtap.search, though, because I'm already preparing the move to using rtcons in there (maintaining includeaux).
Configuration menu - View commit details
-
Copy full SHA for 5cdfef0 - Browse repository at this point
Copy the full SHA 5cdfef0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f47dde2 - Browse repository at this point
Copy the full SHA f47dde2View commit details -
Also, adding the forgotten _keyword attributes for Waveband and Servicetype so they'll later be found when moving regtap.search.
Configuration menu - View commit details
-
Copy full SHA for 4622f68 - Browse repository at this point
Copy the full SHA 4622f68View commit details -
Reworking regtap.query to work with our new constraints.
This required changing some of the constraints in order to keep the existing call patterns stable.
Configuration menu - View commit details
-
Copy full SHA for 6512104 - Browse repository at this point
Copy the full SHA 6512104View commit details -
Configuration menu - View commit details
-
Copy full SHA for 767f16d - Browse repository at this point
Copy the full SHA 767f16dView commit details -
Adding an Interface class to regtap to hold results for our now regul…
…arly multi-interface results. We're now also retrieving the interface type because we may want to do something with web interfaces at some point. Also, waveband validation is now case-insenstitive.
Configuration menu - View commit details
-
Copy full SHA for aa930d3 - Browse repository at this point
Copy the full SHA aa930d3View commit details -
Extracting registry.search query building to a get_RegTAP_query funct…
…ion. Also, refactoring service type selection to use a global SERVICE_TYPE_MAP for the various aliases for the standards. Also, adding an Ivoid constraint for just retrieving a specific resource.
Configuration menu - View commit details
-
Copy full SHA for 85e9f00 - Browse repository at this point
Copy the full SHA 85e9f00View commit details -
Further steps towards improved service selection.
Interfaces now know if they're VOSI and are filtered by service, new way of expanding and shortinging standard ids. But we're stuck a bit because of a conspiracy between RegTAP's NULL mapping rules, ivo_string_agg's NULL skipping, and the lack of COALESCE in ADQL.
Configuration menu - View commit details
-
Copy full SHA for a9ca306 - Browse repository at this point
Copy the full SHA a9ca306View commit details -
RegTAP now employs COALESCE in the interface aggregates.
This is nice and makes our "get all interfaces"-queries work. It's only downside: This only exists in bleeding-edge DaCHSes, as far as ADQL is concerned.
Configuration menu - View commit details
-
Copy full SHA for c1fb437 - Browse repository at this point
Copy the full SHA c1fb437View commit details -
Work on interface selection by ~standard id.
The effect of this commit is that you can say svc.get_service("tap") and receive a TAP service if there's a tap or tap#aux capability. You can now also say svc.get_service("web") to get a browser interface.
Configuration menu - View commit details
-
Copy full SHA for eed306e - Browse repository at this point
Copy the full SHA eed306eView commit details -
Configuration menu - View commit details
-
Copy full SHA for df923b0 - Browse repository at this point
Copy the full SHA df923b0View commit details -
Adding a get_contact method to RegistryResource to figure out who cou…
…ld do tech support.
Configuration menu - View commit details
-
Copy full SHA for c411f8b - Browse repository at this point
Copy the full SHA c411f8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee73bab - Browse repository at this point
Copy the full SHA ee73babView commit details -
Also, changing the default endpoint to reg.g-vo.org, which is dc.g-vo with failovers in case anything is funny in Heidelberg.
Configuration menu - View commit details
-
Copy full SHA for 10ce5ce - Browse repository at this point
Copy the full SHA 10ce5ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for da6d4c3 - Browse repository at this point
Copy the full SHA da6d4c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9a2be8 - Browse repository at this point
Copy the full SHA e9a2be8View commit details -
registry: Adding a workaround for automatic access URL selection
when services declare multiple data models with matching prefixes.
Configuration menu - View commit details
-
Copy full SHA for 663befe - Browse repository at this point
Copy the full SHA 663befeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d4f4661 - Browse repository at this point
Copy the full SHA d4f4661View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16d3d78 - Browse repository at this point
Copy the full SHA 16d3d78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4611a4e - Browse repository at this point
Copy the full SHA 4611a4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 52e5b29 - Browse repository at this point
Copy the full SHA 52e5b29View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3741aa - Browse repository at this point
Copy the full SHA d3741aaView commit details -
Making resource lists accessibles through short names, too
Actually, you can even use ivoids if things really need to be repeatable.
Configuration menu - View commit details
-
Copy full SHA for b8c84be - Browse repository at this point
Copy the full SHA b8c84beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fffbbe - Browse repository at this point
Copy the full SHA 9fffbbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for d68a27e - Browse repository at this point
Copy the full SHA d68a27eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04dd076 - Browse repository at this point
Copy the full SHA 04dd076View commit details -
Configuration menu - View commit details
-
Copy full SHA for b617f28 - Browse repository at this point
Copy the full SHA b617f28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 799abe0 - Browse repository at this point
Copy the full SHA 799abe0View commit details -
Fixes for Birgitta's first review comments.
That is: * Changelog mentions PR rather than bugs * __all__ declaration for the rtcons module.
Configuration menu - View commit details
-
Copy full SHA for 8590490 - Browse repository at this point
Copy the full SHA 8590490View commit details -
Fixing RegistryResource.describe for multi-capability resources.
The previous code assumed that typically, records only have one capability, which is no longer true as soon as people do not constrain by servicetype (actually, it hasn't been true before either). So, describe() now gives the various access methods and no longer tries to indicate a specific capability. I have re-shuffled the order of the outputs a bit in consequence. And I wonder if this should show contact information by default. The main counterargument at this point: That requires a network request.
Configuration menu - View commit details
-
Copy full SHA for ea4787e - Browse repository at this point
Copy the full SHA ea4787eView commit details -
The Servicetype constraint now accepts local parts of the ivoid, too.
This corresponds to the legacy behaviour.
Configuration menu - View commit details
-
Copy full SHA for b9bd35e - Browse repository at this point
Copy the full SHA b9bd35eView commit details -
Adding (back?) source_value to RegistryResource.
This addresses review comment astropy#289 (review)
Configuration menu - View commit details
-
Copy full SHA for 10e4ccb - Browse repository at this point
Copy the full SHA 10e4ccbView commit details -
Adding an origin attribute to VOSI tables coming from RegistryResource.
This points back to the parent instance. This is an attempt to address astropy#289 (comment)
Configuration menu - View commit details
-
Copy full SHA for 293be23 - Browse repository at this point
Copy the full SHA 293be23View commit details -
Minor editorial changes, mainly to documentation.
Also, adding a __repr__ method to regtap.Interface that returns a constructor call literal. This is in response to astropy#289 (review)
Configuration menu - View commit details
-
Copy full SHA for fb750cc - Browse repository at this point
Copy the full SHA fb750ccView commit details -
Renaming previous RegistryResults.to_table to get_summary.
This is because overwriting DALResults.to_table proved a bad idea (see astropy#289 (comment))
Configuration menu - View commit details
-
Copy full SHA for 10452ec - Browse repository at this point
Copy the full SHA 10452ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b5a2e1 - Browse repository at this point
Copy the full SHA 1b5a2e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b3ba96d - Browse repository at this point
Copy the full SHA b3ba96dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c313f7 - Browse repository at this point
Copy the full SHA 0c313f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f4bfe5 - Browse repository at this point
Copy the full SHA 9f4bfe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2314e27 - Browse repository at this point
Copy the full SHA 2314e27View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae43aa1 - Browse repository at this point
Copy the full SHA ae43aa1View commit details
Commits on Jun 2, 2022
-
Making tests using the messenger vocabulary non-remote.
The messenger_vocabulary fixture should have made them non-remote, but I've never actually tested that. It now turns out that astropy.data doesn't use requests and hence my nice requests mocker just didn't work. I've now replaced it by code seeding astropy.data's cache. This is a pattern we ought to use whenever code uses IVOA vocabularies. I wonder where we should document this?
Configuration menu - View commit details
-
Copy full SHA for cc2967c - Browse repository at this point
Copy the full SHA cc2967cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dc5dd7 - Browse repository at this point
Copy the full SHA 6dc5dd7View commit details
Commits on Jun 3, 2022
-
Adding forgotten registry.tests.commonfixtures.
(sorry; also, I'm busy elsewhere, so I'll address the remaining issues on Monday)
Configuration menu - View commit details
-
Copy full SHA for 53dee40 - Browse repository at this point
Copy the full SHA 53dee40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47026f1 - Browse repository at this point
Copy the full SHA 47026f1View commit details