Updated continuous integration #38

astrofrog · 2023-09-11T13:25:53Z

Just simplifying the CI and adding recent versions of pytest

Fix #39

pllim · 2023-09-11T13:27:33Z

Should we just drop pytest<6?

pllim · 2023-09-11T13:27:56Z

CI disabled. Gonna close/reopen to trigger it.

astrofrog · 2023-09-11T13:39:34Z

@pllim - I don't think we need to drop any pytest versions at this point, think it should all work

pllim · 2023-09-11T13:40:19Z

You wanna be adventurous and have pytestdev use Python 3.12? 😅

astrofrog · 2023-09-11T13:40:45Z

Does Python 3.12 work with the openastronomy workflows?

pllim · 2023-09-11T13:43:36Z

I have no idea. I just know @bsipocz added a Python 3.12 job for pytest-doctestplus (and I don't have time to check right now).

astrofrog · 2023-09-11T13:54:01Z

@pllim lets just merge this for now if you are happy with it and I can investigate separately?

pllim · 2023-09-11T14:00:37Z

.github/workflows/ci_workflows.yml

+        - macos: py310-test-pytest73
+        - windows: py311-test-pytest74
+        - linux: py311-test-pytestdev
+  publish:


What does this mean? Can we still use the "Build wheels" label on PRs here?

The wheels are always built in PRs with this config. It's so fast there's no point making it optional.

Wheels will always be built but only published to PyPI on a tag

OK so after we have merged this, we should delete that "Build wheels" label.

pllim · 2023-09-11T14:08:43Z

This drops Python 3.7 testing without dropping Python 3.7 support. Should we just drop 3.7 completely?

pytest-arraydiff/setup.cfg

Line 30 in e006ea1

python_requires = >=3.7

astrofrog · 2023-09-11T14:12:06Z

Oops yes meant to update setup.cfg

bsipocz · 2023-09-11T16:48:32Z

IMO, do one last release before dropping 3.7, that's what we did elsewhere. Or is it hopelessly incompatible already?

bsipocz · 2023-09-11T16:53:58Z

Re py3.12: there wasn't any big issues, but this one fix was needed, which may or may not effect this plugin: scientific-python/pytest-doctestplus#215

astrofrog · 2023-09-11T18:39:25Z

Can add back python 3.7, not a problem!

astrofrog · 2023-09-11T19:31:22Z

I've added back Python 3.7, hopefully this should still pass

tox.ini

pllim

LGTM but I'll let Brigitta have a look too. Thanks!

bsipocz

Versions certainly need to be updated, but I don't see why relying on a middle layer makes sense for these super simple plugins.

.github/workflows/ci_workflows.yml

bsipocz · 2023-09-11T23:16:55Z

.github/workflows/ci_workflows.yml

+    uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@v1
+    with:
+      envs: |
+        - linux: py37-test-pytest46


Somewhat unrelated improvement: instead of pytest46 I like to call it pytestoldest, and pin it to the actual stated minimum version rather than a wildcard in that series. E.g. pytest==4.6.0

If a fix is needed from an actual bugfix, then bump the minimum version to reflect that.

(for the rest of the versions I feel the flexible wildcard is fine, we need a wide enough matrix to cover over versions but don't need to test everything).

Sounds good, will do

bsipocz · 2023-09-11T23:18:08Z

Oh, and I can repeat what @pllim said above, please add py3.12 testing (can be done separately, but it's really time to make stuff compatible if it's not yet)

pllim · 2023-09-12T01:26:14Z

FWIW, I opened:

Compatibility with NumPy 2.0 and Python 3.12 #39

astrofrog · 2023-09-12T10:46:30Z

This fails on Python 3.12 - @pllim @bsipocz is that an error you've seen before?

.github/workflows/ci_workflows.yml

tox.ini

pllim · 2023-09-12T13:26:22Z

I don't think you can pull astropy or tables for py312. You also have to pull in pandas dev.

pytest-arraydiff/setup.cfg

Lines 37 to 41 in e006ea1

    
           [options.extras_require] 
        
           test = 
        
               astropy 
        
               pandas 
        
               tables

astrofrog · 2023-09-12T13:36:20Z

Hmm at the moment astropy is a required dependency for the test suite. Rather than re-write everything maybe we can just wait?

pllim · 2023-09-12T13:38:50Z

Wait for a miracle?

tox.ini

Simplified publish workflow Make publish job dependent on tests Add back Python 3.7 Rename pytest46 to pytestoldest and add Python 3.12 testing Use latest developer version of Numpy and pytest for Python 3.12 Co-authored-by: P. L. Lim <[email protected]>

across the board and add the codestyle check. Fix PEP 8 complaints. Auto-cancel duplicate Action jobs.

Handle FutureWarning from pandas 3.0 Skip failing pandas test caused by numpy 2.0 Updated matrix to run a stable job in py312

pllim · 2023-11-15T23:05:23Z

Gonna merge and then do a release. 🤞

pllim closed this Sep 11, 2023

pllim reopened this Sep 11, 2023

astrofrog force-pushed the fix-pytest-72 branch from 1b09785 to c0a3bda Compare September 11, 2023 13:36

astrofrog changed the title ~~Fixes for recent versions of pytest~~ Updated continuous integration Sep 11, 2023

astrofrog marked this pull request as ready for review September 11, 2023 13:56

pllim reviewed Sep 11, 2023

View reviewed changes

astrofrog requested a review from pllim September 11, 2023 20:26

pllim reviewed Sep 11, 2023

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

pllim approved these changes Sep 11, 2023

View reviewed changes

pllim requested a review from bsipocz September 11, 2023 22:58

bsipocz reviewed Sep 11, 2023

View reviewed changes

astrofrog force-pushed the fix-pytest-72 branch from 5d96746 to 18be9b8 Compare September 12, 2023 10:14

pllim reviewed Sep 12, 2023

View reviewed changes

.github/workflows/ci_workflows.yml Outdated Show resolved Hide resolved

pllim reviewed Sep 12, 2023

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

astrofrog force-pushed the fix-pytest-72 branch from 3abe6e9 to c745a36 Compare September 12, 2023 13:24

bsipocz reviewed Sep 13, 2023

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

Updated CI configuration

dfa69c6

Simplified publish workflow Make publish job dependent on tests Add back Python 3.7 Rename pytest46 to pytestoldest and add Python 3.12 testing Use latest developer version of Numpy and pytest for Python 3.12 Co-authored-by: P. L. Lim <[email protected]>

pllim force-pushed the fix-pytest-72 branch 2 times, most recently from 25b0076 to 98e772b Compare November 15, 2023 22:15

Make sure test matrix is consistent

86fd58c

across the board and add the codestyle check. Fix PEP 8 complaints. Auto-cancel duplicate Action jobs.

pllim force-pushed the fix-pytest-72 branch 2 times, most recently from d8a4e31 to beba1cb Compare November 15, 2023 22:31

Need astropy-dev and pandas-dev to go with numpy-dev

754a8bd

Handle FutureWarning from pandas 3.0 Skip failing pandas test caused by numpy 2.0 Updated matrix to run a stable job in py312

pllim force-pushed the fix-pytest-72 branch from fc0d0d7 to 754a8bd Compare November 15, 2023 22:56

pllim mentioned this pull request Nov 15, 2023

test_succeeds_func_pdhdf fails with numpy 2.0, currently skipped in devdeps #41

Open

pllim merged commit bab9723 into astropy:main Nov 15, 2023
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated continuous integration #38

Updated continuous integration #38

astrofrog commented Sep 11, 2023 •

edited by pllim

Loading

pllim commented Sep 11, 2023

pllim commented Sep 11, 2023

astrofrog commented Sep 11, 2023

pllim commented Sep 11, 2023

astrofrog commented Sep 11, 2023

pllim commented Sep 11, 2023 •

edited

Loading

astrofrog commented Sep 11, 2023 •

edited

Loading

pllim Sep 11, 2023

astrofrog Sep 11, 2023 •

edited

Loading

astrofrog Sep 11, 2023

pllim Sep 11, 2023

pllim commented Sep 11, 2023

astrofrog commented Sep 11, 2023

bsipocz commented Sep 11, 2023

bsipocz commented Sep 11, 2023

astrofrog commented Sep 11, 2023

astrofrog commented Sep 11, 2023

pllim left a comment

bsipocz left a comment

bsipocz Sep 11, 2023

astrofrog Sep 12, 2023

bsipocz commented Sep 11, 2023

pllim commented Sep 12, 2023

astrofrog commented Sep 12, 2023

pllim commented Sep 12, 2023

astrofrog commented Sep 12, 2023

pllim commented Sep 12, 2023

pllim commented Nov 15, 2023

Updated continuous integration #38

Updated continuous integration #38

Conversation

astrofrog commented Sep 11, 2023 • edited by pllim Loading

pllim commented Sep 11, 2023

pllim commented Sep 11, 2023

astrofrog commented Sep 11, 2023

pllim commented Sep 11, 2023

astrofrog commented Sep 11, 2023

pllim commented Sep 11, 2023 • edited Loading

astrofrog commented Sep 11, 2023 • edited Loading

pllim Sep 11, 2023

Choose a reason for hiding this comment

astrofrog Sep 11, 2023 • edited Loading

Choose a reason for hiding this comment

astrofrog Sep 11, 2023

Choose a reason for hiding this comment

pllim Sep 11, 2023

Choose a reason for hiding this comment

pllim commented Sep 11, 2023

astrofrog commented Sep 11, 2023

bsipocz commented Sep 11, 2023

bsipocz commented Sep 11, 2023

astrofrog commented Sep 11, 2023

astrofrog commented Sep 11, 2023

pllim left a comment

Choose a reason for hiding this comment

bsipocz left a comment

Choose a reason for hiding this comment

bsipocz Sep 11, 2023

Choose a reason for hiding this comment

astrofrog Sep 12, 2023

Choose a reason for hiding this comment

bsipocz commented Sep 11, 2023

pllim commented Sep 12, 2023

astrofrog commented Sep 12, 2023

pllim commented Sep 12, 2023

astrofrog commented Sep 12, 2023

pllim commented Sep 12, 2023

pllim commented Nov 15, 2023

astrofrog commented Sep 11, 2023 •

edited by pllim

Loading

pllim commented Sep 11, 2023 •

edited

Loading

astrofrog commented Sep 11, 2023 •

edited

Loading

astrofrog Sep 11, 2023 •

edited

Loading