-
-
Notifications
You must be signed in to change notification settings - Fork 34
Adding [docs only] and [build docs] custom tags #199
Conversation
@Cadair @astrofrog - I fear this is something that cannot really be tested within this repo, if you up to it, please give it a go. (E.g. without usage I've totally forgotten within a month that |
…ld docs], and [docs only]
…it by: [skip travis] [skip appveyor]
1ec45e2
to
4bbbb4f
Compare
I'll send out an e-mail to astropy-dev and the maintainers list about this, but also tagging a few people who I know are keen to keep the CI footprint minimal (though it would be great to educate the less keen people about the merits of it). @mhvk @hamogu @cdeil @MSeifert04 @eteq @astrofrog @pllim @larrybradley @Cadair @mwcraig All the new custom tags work like the prerelease builds, and set the commit status to pass. Obviously it doesn't mean that the tests are passing. We can assume that the author has good reasons for the skip, but maintainers should be aware of this, too to avoid after merge surprises. So, now we have These tags cannot be tested in this repo, but I run a few tests elsewhere. While it works as expected, please look out for issues that are related to this. |
Fantastic! We should be sure to document it also in the development guide. |
That's a great addition. Thanks, @bsipocz ! |
This is excellent !! |
This is great. Thanks, @bsipocz! |
@bsipocz I'm not sure but this might have broken the cron job for MDAnalysis. For us it is now always run. Even during a normal PR. Below is an example job with |
@kain88-de - Indeed, this PR cleans up a bit of the logic, and does all checking for cancelling builds before any install happens. I suggest to use common |
Ah yeah thank you. I overlooked that we use the specific init script. |
Minor clean up of [travis skip], and addition of two new custom tags to the top level script.
This address all ideas in and thus close #188