Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Adding [docs only] and [build docs] custom tags #199

Merged
merged 5 commits into from
Jun 8, 2017

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jun 7, 2017

Minor clean up of [travis skip], and addition of two new custom tags to the top level script.

This address all ideas in and thus close #188

@bsipocz
Copy link
Member Author

bsipocz commented Jun 7, 2017

@Cadair @astrofrog - I fear this is something that cannot really be tested within this repo, if you up to it, please give it a go. (E.g. without usage I've totally forgotten within a month that [skip travis] is already a thing...)

@bsipocz bsipocz force-pushed the custom_tags branch 3 times, most recently from 1ec45e2 to 4bbbb4f Compare June 8, 2017 00:01
@bsipocz bsipocz merged commit f575e90 into astropy:master Jun 8, 2017
@bsipocz
Copy link
Member Author

bsipocz commented Jun 8, 2017

I'll send out an e-mail to astropy-dev and the maintainers list about this, but also tagging a few people who I know are keen to keep the CI footprint minimal (though it would be great to educate the less keen people about the merits of it). @mhvk @hamogu @cdeil @MSeifert04 @eteq @astrofrog @pllim @larrybradley @Cadair @mwcraig

All the new custom tags work like the prerelease builds, and set the commit status to pass. Obviously it doesn't mean that the tests are passing. We can assume that the author has good reasons for the skip, but maintainers should be aware of this, too to avoid after merge surprises.

So, now we have [skip travis] and [travis skip] to skip travis. And more importantly have [docs only] or [build docs] that will skip all jobs except the docs building ones.

These tags cannot be tested in this repo, but I run a few tests elsewhere. While it works as expected, please look out for issues that are related to this.

@mhvk
Copy link

mhvk commented Jun 8, 2017

Fantastic! We should be sure to document it also in the development guide.

@pllim
Copy link
Member

pllim commented Jun 8, 2017

That's a great addition. Thanks, @bsipocz !

@mwcraig
Copy link
Member

mwcraig commented Jun 8, 2017

This is excellent !!

@larrybradley
Copy link
Member

This is great. Thanks, @bsipocz!

@kain88-de
Copy link
Contributor

@bsipocz I'm not sure but this might have broken the cron job for MDAnalysis. For us it is now always run. Even during a normal PR. Below is an example job with DEBUG=True

Cron Job
Whole Travis Build

@bsipocz
Copy link
Member Author

bsipocz commented Jun 17, 2017

@kain88-de - Indeed, this PR cleans up a bit of the logic, and does all checking for cancelling builds before any install happens. I suggest to use common setup_conda.py (as shown in the README) rather than the OS specific setup files.

@kain88-de
Copy link
Contributor

Ah yeah thank you. I overlooked that we use the specific init script.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create custom skip tags
7 participants