-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor WFAU image retrieval to reject deprecated images #2809
Draft
keflavich
wants to merge
12
commits into
astropy:main
Choose a base branch
from
keflavich:issue2808_wfau_deprecated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d070bdf
refactor wfau to retrieve metadata about images and reject deprecated…
keflavich 2fa5050
codestyle
keflavich 6d16328
WIP: trying to fix radius=not None queries
keflavich bfd412e
update reader for radius!=None searches, and correspondingly update t…
keflavich e3e4905
restore extract_urls - used by other things
keflavich 3a7b298
tests of different image result queries
keflavich c4db9fb
update test data
keflavich 79fd880
update tests to match new data
keflavich 75e4726
change remote test
keflavich 5ac89b0
avoid reusing variable
keflavich ed94efe
add changelog entry
keflavich 8733870
privatize _extract_urls & try to fix a broken old test
keflavich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I commented this before in another module: I think methods like this should not be class methods, definitely not public ones, but instead private functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I agree - happy to make this, and
get_image_list
, both privateThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can't make
get_image_list
private, at least not without a deprecation period.