Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor benchmarking process to run relative benchmark for PR #106

Closed
pllim opened this issue Nov 19, 2021 · 2 comments
Closed

Refactor benchmarking process to run relative benchmark for PR #106

pllim opened this issue Nov 19, 2021 · 2 comments

Comments

@pllim
Copy link
Member Author

pllim commented Nov 11, 2022

For the GitHub Actions route, I think https://github.com/scikit-image/scikit-image/blob/main/benchmarks/README_CI.md sums up the expectations. We will never get an absolute number, only will know if a change introduced in a PR has changed performance significantly or not. So, if you are looking for absolutes (e.g., exactly how long is needed to run something and how that changes over time) or comparison with delta smaller than sensitivity of the CI, then this is not for you.

@pllim
Copy link
Member Author

pllim commented Mar 16, 2024

Done in astropy/astropy#15779 thanks to @MridulS !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant