Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmark codes to astropy core lib and only keep results here #102

Closed
pllim opened this issue Feb 22, 2021 · 5 comments
Closed

Move benchmark codes to astropy core lib and only keep results here #102

pllim opened this issue Feb 22, 2021 · 5 comments

Comments

@pllim
Copy link
Member

pllim commented Feb 22, 2021

As asked by @Cadair , is there any good reason why the benchmarking code cannot be in astropy repo? Can we move the code to astropy and only keep the results here?

@astrofrog , do you remember why this is a separate repo?

@astrofrog
Copy link
Member

Historically this was because we kept results and benchmarks in the same branch so it made sense to keep this in a separate repo. But since the results and benchmarks live on a different branch anyway I think the benchmarks could just live in the main repo. Having said that I don't know how asv would deal with the list of benchmarks changing over time. If someone can show it would work, I'd be on board with this!

@Cadair
Copy link
Member

Cadair commented Mar 2, 2021

asv appears to handle it fine on our initial testing with sunpy

@astrofrog
Copy link
Member

I guess one definite limitation is that we wouldn't be able to run benchmarks backwards, on older commits, right?

@Cadair
Copy link
Member

Cadair commented Mar 3, 2021

You appear to still be able to do that, asv appears to read the benchmarks from the latest commit and then runs them on older code.

@MridulS
Copy link
Contributor

MridulS commented Jan 31, 2024

I guess we should probably not be moving the benchmarks to the core lib? astropy/astropy#15779 (comment) It will be a lot of data and other files.

@pllim pllim closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants