Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test RC provider packages for https://github.com/apache/airflow/issues/33257 #1293

Closed
wants to merge 11 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 9, 2023

No description provided.

@Lee-W
Copy link
Contributor

Lee-W commented Aug 9, 2023

Thanks, @pankajkoti, for running this. It seems the latest test failure relates to apache/airflow#32767, but not google provider. I'll go with +1 on the dev group

@pankajkoti
Copy link
Collaborator

pankajkoti commented Aug 9, 2023

yes, @Lee-W I am just figuring out what's going on wrong in the CI, but please go ahead with our +1 vote

@pankajkoti
Copy link
Collaborator

pankajkoti commented Aug 9, 2023

I am wondering why would it fail our CI as we use Airflow 2.6.3 in our CI and that would still have those modules existing.

Also why do those tests run fine for Python 3.11 and fail for others? The tests run fine for me locally on Python3.10 with runtime image.

@Lee-W
Copy link
Contributor

Lee-W commented Aug 10, 2023

Could it relate to 2.7.0b0 ?

@pankajkoti
Copy link
Collaborator

pankajkoti commented Aug 10, 2023

Could it relate to 2.7.0b0 ?

I tried to check the pip packages installed in the CI, but it says it is installing 2.6.3. I had a guess that maybe it is using some common cache, so tried invalidating cache, but still could not figure out what's going wrong here

There were other issues too yesterday Astro SDK, and providers alpha1, so could not investigate further here.

@Lee-W Lee-W force-pushed the rc-test-2023-08-09T13-27-20UTC branch from 1e0e101 to 415b95b Compare August 10, 2023 06:39
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c6a7fc3) 98.57% compared to head (8a02294) 98.57%.

❗ Current head 8a02294 differs from pull request most recent head 3993eaa. Consider uploading reports for the commit 3993eaa to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1293   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          91       91           
  Lines        5404     5404           
=======================================
  Hits         5327     5327           
  Misses         77       77           
Files Changed Coverage Δ
astronomer/providers/core/sensors/external_task.py 95.83% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajkoti
Copy link
Collaborator

Please don't rebase this branch

@pankajkoti
Copy link
Collaborator

Closing this. However, there was no conclusion on why it tried to install beta versions of Apache Airflow and also why it collected the package twice.

@pankajkoti pankajkoti closed this Aug 16, 2023
@github-actions github-actions bot deleted the rc-test-2023-08-09T13-27-20UTC branch August 16, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants