-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building DbtDag
without setting paths in ProjectConfig
#1307
Conversation
…onfig Previously, users were unable to run a DbtDag or DbtTask group where the following was used: - RenderMode.DBT_LS - ExecutionConfig(dbt_project_path) - RenderConfig(dbt_project_path) This scenario can be useful when using ExecutionMode.KUBERNETES or other similar ones and was found out during: #1297
Deploying astronomer-cosmos with Cloudflare Pages
|
DbtToAirflowConverter
to work without ProjectConfig
pathsDbtDag
without setting paths in ProjectConfig
There are two checks currently failing in this PR:
The current PR causes neither issue. I rebased PR #1297 using this branch and confirmed both issues are resolved in: https://github.com/astronomer/astronomer-cosmos/actions/runs/11706266140 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for finding the issue, isolating & creating a PR for this. Looks robust now.
Previously, users were unable to run a DbtDag or DbtTask group where the following was used:
RenderMode.DBT_LS
ExecutionConfig(dbt_project_path)
RenderConfig(dbt_project_path)
This scenario can be helpful when using ExecutionMode.KUBERNETES or other similar ones and was found out during: #1297