Document for append operator #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
reviewed
Aug 9, 2022
Co-authored-by: Pankaj Koti <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #619 +/- ##
=======================================
Coverage 93.30% 93.30%
=======================================
Files 41 41
Lines 1672 1672
Branches 211 211
=======================================
Hits 1560 1560
Misses 89 89
Partials 23 23 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kaxil
approved these changes
Aug 9, 2022
pankajkoti
approved these changes
Aug 9, 2022
| output_table=Table(conn_id="postgres_conn"), | ||
| ) | ||
| load_append = aql.load_file( | ||
| input_file=File(path=DATA_DIR + "/homes2.csv"), |
There was a problem hiding this comment.
Suggested change
| input_file=File(path=DATA_DIR + "/homes2.csv"), | |
| input_file=File(path=DATA_DIR + "homes2.csv"), |
We have an extra / here
kaxil
pushed a commit
that referenced
this pull request
Aug 18, 2022
What is the current behavior? In the past, we had a tutorial which illustrated how to use each of our operators/decorators: https://github.com/astronomer/astro-sdk/blob/be6280df00ccff0d7a1c0dfb099b2065303dbe88/REFERENCE.md closes: #590 What is the new behavior? Have a reference page per operator/decorator similar to https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/operators/ecs.html#howto-operator-ecsoperator In which we reference parts of an (automated tested) example DAG which illustrates the usage of that operator/decorator. Many of these use cases already exist in our example DAGs - we should reference them. Does this introduce a breaking change? Nope
kaxil
pushed a commit
that referenced
this pull request
Aug 18, 2022
What is the current behavior? In the past, we had a tutorial which illustrated how to use each of our operators/decorators: https://github.com/astronomer/astro-sdk/blob/be6280df00ccff0d7a1c0dfb099b2065303dbe88/REFERENCE.md closes: #590 What is the new behavior? Have a reference page per operator/decorator similar to https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/operators/ecs.html#howto-operator-ecsoperator In which we reference parts of an (automated tested) example DAG which illustrates the usage of that operator/decorator. Many of these use cases already exist in our example DAGs - we should reference them. Does this introduce a breaking change? Nope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the current behavior?
In the past, we had a tutorial which illustrated how to use each of our operators/decorators:
https://github.com/astronomer/astro-sdk/blob/be6280df00ccff0d7a1c0dfb099b2065303dbe88/REFERENCE.md
closes: #590
What is the new behavior?
Have a reference page per operator/decorator similar to
https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/operators/ecs.html#howto-operator-ecsoperator
In which we reference parts of an (automated tested) example DAG which illustrates the usage of that operator/decorator.
Many of these use cases already exist in our example DAGs - we should reference them.
Does this introduce a breaking change?
Nope
Checklist