Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix S3provider issue #1846

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Fix S3provider issue #1846

merged 2 commits into from
Mar 14, 2023

Conversation

utkarsharma2
Copy link
Collaborator

Description

What is the current behavior?

Fix s3 provider issue, needs {} instead of None intransfer_config_args config.

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -9.80 ⚠️

Comparison is base (08b7367) 74.78% compared to head (0d5c16a) 64.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1846      +/-   ##
==========================================
- Coverage   74.78%   64.98%   -9.80%     
==========================================
  Files          54       54              
  Lines        2399     2399              
  Branches      146      146              
==========================================
- Hits         1794     1559     -235     
- Misses        560      801     +241     
+ Partials       45       39       -6     
Flag Coverage Δ
UTO 45.21% <0.00%> (-15.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nsfer_operator/data_providers/filesystem/aws/s3.py 0.00% <0.00%> (-52.09%) ⬇️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utkarsharma2 utkarsharma2 merged commit 14bb7c3 into main Mar 14, 2023
@utkarsharma2 utkarsharma2 deleted the Fix-airflow-2.2.5 branch March 14, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants