Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example dags testcase as part of CI #1845

Merged
merged 5 commits into from
Mar 15, 2023
Merged

Add example dags testcase as part of CI #1845

merged 5 commits into from
Mar 15, 2023

Conversation

utkarsharma2
Copy link
Collaborator

Description

What is the current behavior?

Add example dags as part of integration tests.

@utkarsharma2 utkarsharma2 marked this pull request as draft March 14, 2023 15:22
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +10.28 🎉

Comparison is base (14bb7c3) 74.82% compared to head (087c211) 85.10%.

❗ Current head 087c211 differs from pull request most recent head 8ca6da7. Consider uploading reports for the commit 8ca6da7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1845       +/-   ##
===========================================
+ Coverage   74.82%   85.10%   +10.28%     
===========================================
  Files          54      124       +70     
  Lines        2399     6485     +4086     
  Branches      146      643      +497     
===========================================
+ Hits         1795     5519     +3724     
- Misses        559      824      +265     
- Partials       45      142       +97     
Flag Coverage Δ
PythonSDK 91.47% <ø> (?)
SQL-CLI 97.67% <ø> (ø)
UTO 60.14% <100.00%> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/universal_transfer_operator/datasets/table.py 69.51% <100.00%> (+4.95%) ⬆️

... and 82 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@utkarsharma2 utkarsharma2 marked this pull request as ready for review March 14, 2023 18:54
Copy link
Collaborator

@dimberman dimberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments but overal LGTM

@utkarsharma2 utkarsharma2 merged commit ba26711 into main Mar 15, 2023
@utkarsharma2 utkarsharma2 deleted the example-dag-ci branch March 15, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants