Skip to content

Commit

Permalink
Disable schedule astro-deploy job and run the RC test scheduled job o…
Browse files Browse the repository at this point in the history
…nly once a day (#2136)

Since we have a job to test upstream RCs, and additionally 
our CI runs integrations tests on every PR, we can disable 
the scheduled astro deploy job for now to reduce our cloud costs. 
In the future, in case we need to run this on schedule, we can 
enable it again by uncommenting the schedule.

Additionally, I am changing the RC test scheduled job to run only 
once a day instead of running it twice. We need to further 
optimise that job to trigger a deploy only when actual RCs are out. 
At the moment, we run the deploy and master DAG irrespective of 
RCs being out.
  • Loading branch information
pankajkoti authored Apr 5, 2024
1 parent 901d7c0 commit ea2b3fc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/ci-astro-deploy.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
name: "Astro Deploy"
on:
schedule:
- cron: '0 19 * * *'
# Since we have a job to test upstream RCs, and additionally our CI runs integrations tests on every PR,
# we can disable this scheduled job for now. In the future, in case we need to run this on schedule, we
# can enable it again by uncommenting the below schedule.
# schedule:
# - cron: '0 19 * * *'
workflow_dispatch:
inputs:
git_rev:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-rc-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Test providers RC releases

on: # yamllint disable-line rule:truthy
schedule:
- cron: "0 0,12 * * *"
- cron: "0 0 * * *"
workflow_dispatch:
inputs:
rc_testing_branch:
Expand Down

0 comments on commit ea2b3fc

Please sign in to comment.