Skip to content

Commit

Permalink
use asdict
Browse files Browse the repository at this point in the history
  • Loading branch information
pankajastro committed Jan 5, 2023
1 parent e3894e4 commit 6870fc6
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion python-sdk/src/astro/files/types/csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io

import attr
import pandas as pd

from astro.constants import FileType as FileTypeConstants
Expand Down Expand Up @@ -31,7 +32,7 @@ def export_to_dataframe(
in the resulting dataframe
"""
if isinstance(load_options, PandasLoadOptions):
kwargs.update(load_options.to_dict)
kwargs.update(attr.asdict(load_options))
df = pd.read_csv(stream, **kwargs)
df = convert_columns_names_capitalization(
df=df, columns_names_capitalization=columns_names_capitalization
Expand Down
3 changes: 2 additions & 1 deletion python-sdk/src/astro/files/types/json.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io

import attr
import pandas as pd

from astro.constants import FileType as FileTypeConstants
Expand Down Expand Up @@ -34,7 +35,7 @@ def export_to_dataframe(
# Pandas `read_json` does not support the `nrows` parameter unless we're using NDJSON
kwargs_copy.pop("nrows", None)
if isinstance(load_options, PandasLoadOptions):
kwargs_copy.update(load_options.to_dict)
kwargs_copy.update(attr.asdict(load_options))
df = pd.read_json(stream, **kwargs_copy)
df = convert_columns_names_capitalization(
df=df, columns_names_capitalization=columns_names_capitalization
Expand Down
3 changes: 2 additions & 1 deletion python-sdk/src/astro/files/types/ndjson.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import io
import json

import attr
import pandas as pd

from astro.constants import DEFAULT_CHUNK_SIZE, FileType as FileTypeConstants
Expand Down Expand Up @@ -31,7 +32,7 @@ def export_to_dataframe(
in the resulting dataframe
"""
if isinstance(load_options, PandasLoadOptions):
kwargs.update(load_options.to_dict)
kwargs.update(attr.asdict(load_options))
df = NDJSONFileType.flatten(self.normalize_config, stream, **kwargs)
df = convert_columns_names_capitalization(
df=df, columns_names_capitalization=columns_names_capitalization
Expand Down
3 changes: 2 additions & 1 deletion python-sdk/src/astro/files/types/parquet.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io

import attr
import pandas as pd

from astro.constants import FileType as FileTypeConstants
Expand Down Expand Up @@ -35,7 +36,7 @@ def export_to_dataframe(

byte_io_buffer = self._convert_remote_file_to_byte_stream(stream)
if isinstance(load_options, PandasLoadOptions):
kwargs_copy.update(load_options.to_dict)
kwargs_copy.update(attr.asdict(load_options))

df = pd.read_parquet(byte_io_buffer, **kwargs_copy)
df = convert_columns_names_capitalization(
Expand Down

0 comments on commit 6870fc6

Please sign in to comment.