This repository has been archived by the owner on Sep 3, 2020. It is now read-only.
Incorporate changes from bloom-solutions/ruby-stellar-base #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also require bundler ~> 2.0 for development
Looks like 18 was pushed but code isn't found
This was referenced May 6, 2019
|
@nebolsin, as far as I'm concerned it looks good to me, but my Ruby is quite rusty at this point. As long as you and @ramontayag are on the same page, I'll merge it. Can you please fix your conflicts first? |
|
Closing this since the decision was to merge #50 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in astroband/ruby-stellar-sdk#55, this PR incorporates recent changes from bloom-solutions/ruby-stellar-base in order to prepare the proper transfer of this repo to bloom-solutions organization.
I went with manual cherry-picking + some minor fixes along the way, because there're some inconsistencies in the changelog and versions.
/cc @ramontayag @theaeolianmachine