chore(sequencer): change name of source_action_index to position_in_transaction
#1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
proto
ethanoroshiba
changed the title
source_action_index to position_in_transactionsource_action_index to position_in_transaction
joroshiba
reviewed
Oct 25, 2024
proto/sequencerblockapis/astria/sequencerblock/v1alpha1/block.proto
Outdated
Show resolved
Hide resolved
…`position_in_transaction`
ethanoroshiba
force-pushed
the
ENG-950/rename_source_action_index
branch
from
22b75cc
to
b655313
Compare
Fraser999
approved these changes
Dec 2, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changed all non-deposit related instances of
source_action_indextoposition_in_transactionBackground
This is meant to be more descriptive and less confusing to consumers. Deposits should stay the same, though, for parity with Geth and to avoid breaking changes.
Changes
source_action_indextoposition_in_transaction, excluding deposits..Testing
Passing all tests
Related Issues
closes #1735