Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not dereference garbage pointers in sel_buf (doOut) #121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesjer
Copy link

We've been seeing segfaults in Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=1947285. An analysis of the bug is available at that URL. Briefly, sel_buf contains garbage bytes when the while loop is entered, and those bytes can be dereferenced or passed to free().

@spotrh
Copy link

spotrh commented Jun 10, 2021

Worth noting that this solution solves the problem described in PR #117 , but in a way that doesn't break the pathing where sel_buf has data that needs to be freed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants