Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add support for v3 transactions #125

Merged
merged 19 commits into from
Jun 26, 2024

Conversation

JordyRo1
Copy link
Contributor

Resolves #82

Changes

  • ENABLE_STRK_FEES variable defined as environnement variable.
  • Define auto_estimate and l1_resource_bounds for required functions ( if ENABLE_STRK_FEES is True, the user will have to provide either auto_estimate or l1_resource_bounds for the publish to occur.

Questions

  • A small issue is that for the publish_many function we set the auto_estimate to True, to avoid working with fees. However, as shown here, the documentation suggests that it is not recommended to use auto_estimate, since it can lead to more fees.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 37.81%. Comparing base (fd6a42b) to head (bc59f59).

Files Patch % Lines
pragma/core/mixins/oracle.py 7.69% 12 Missing ⚠️
pragma/core/contract.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   37.79%   37.81%   +0.02%     
==========================================
  Files          47       47              
  Lines        3032     3033       +1     
==========================================
+ Hits         1146     1147       +1     
  Misses       1886     1886              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pragma/tests/client_test.py Outdated Show resolved Hide resolved
pragma/tests/client_test.py Show resolved Hide resolved
@EvolveArt EvolveArt merged commit 318d3da into master Jun 26, 2024
3 of 4 checks passed
@EvolveArt EvolveArt deleted the Feat-Add-support-for-v3-transactions branch June 26, 2024 13:38
@JordyRo1 JordyRo1 restored the Feat-Add-support-for-v3-transactions branch July 23, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev: support v3 transactions
2 participants