-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat add support for v3 transactions #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 37.79% 37.81% +0.02%
==========================================
Files 47 47
Lines 3032 3033 +1
==========================================
+ Hits 1146 1147 +1
Misses 1886 1886 ☔ View full report in Codecov by Sentry. |
EvolveArt
approved these changes
Jun 26, 2024
EvolveArt
reviewed
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #82
Changes
ENABLE_STRK_FEES
variable defined as environnement variable.auto_estimate
andl1_resource_bounds
for required functions ( ifENABLE_STRK_FEES
is True, the user will have to provide eitherauto_estimate
orl1_resource_bounds
for the publish to occur.Questions
publish_many
function we set theauto_estimate
to True, to avoid working with fees. However, as shown here, the documentation suggests that it is not recommended to use auto_estimate, since it can lead to more fees.