Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Publishing offchain future assets #109

Merged
merged 27 commits into from
Jun 15, 2024
Merged

feat: Publishing offchain future assets #109

merged 27 commits into from
Jun 15, 2024

Conversation

akhercha
Copy link
Member

@akhercha akhercha commented Jun 11, 2024

Added

  • new linters: ruff + mypy for types

Changed

  • publish_data to offchain future entries

Removed

  • old linters installations & rules

Currently, mypy ignore every source files (see pyproject.toml), an issue will be created to slowly fix them all (there is ~700 atm).
See #116

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 133 lines in your changes missing coverage. Please review.

Project coverage is 38.39%. Comparing base (bd6ffb7) to head (53aaa79).
Report is 1 commits behind head on master.

Current head 53aaa79 differs from pull request most recent head 56e8418

Please upload reports for the commit 56e8418 to get more accurate results.

Files Patch % Lines
pragma/publisher/client.py 22.85% 27 Missing ⚠️
pragma/publisher/fetchers/propeller.py 13.33% 13 Missing ⚠️
pragma/core/randomness/randomness_utils.py 30.76% 9 Missing ⚠️
pragma/publisher/fetchers/thegraph.py 20.00% 8 Missing ⚠️
pragma/core/entry.py 60.00% 6 Missing ⚠️
pragma/publisher/fetchers/starknetamm.py 14.28% 6 Missing ⚠️
pragma/publisher/signer.py 45.45% 6 Missing ⚠️
pragma/core/mixins/oracle.py 0.00% 5 Missing ⚠️
pragma/core/mixins/randomness.py 0.00% 5 Missing ⚠️
pragma/publisher/fetchers/coingecko.py 28.57% 5 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   41.38%   38.39%   -3.00%     
==========================================
  Files          46       45       -1     
  Lines        2931     2873      -58     
==========================================
- Hits         1213     1103     -110     
- Misses       1718     1770      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akhercha akhercha requested a review from EvolveArt June 11, 2024 18:25
pragma/publisher/perp_fetchers/binance.py Outdated Show resolved Hide resolved
pragma/publisher/perp_fetchers/binance.py Outdated Show resolved Hide resolved
pragma/core/mixins/offchain.py Outdated Show resolved Hide resolved
@EvolveArt
Copy link
Contributor

Please also add some tests for the new perp fetcher.

@akhercha akhercha marked this pull request as ready for review June 12, 2024 09:30
@akhercha akhercha requested a review from EvolveArt June 14, 2024 23:10
@EvolveArt EvolveArt merged commit a7054c9 into master Jun 15, 2024
2 checks passed
@EvolveArt EvolveArt deleted the feat/perp_assets branch June 15, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants