Enable uv tool uninstall uv on Windows
#8963
Open
+57
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/self-tool
branch
from
f5c255d
to
0f1fbc1
Compare
charliermarsh
commented
Nov 9, 2024
| let mut existing_entry_points = target_entry_points | ||
| .iter() | ||
| .filter(|(_, _, target_path)| target_path.exists()) | ||
| .peekable(); |
There was a problem hiding this comment.
@zanieb -- I noticed this logic is such that we delete the existing entrypoints, then we write them in the for (name, source_path, target_path) in &target_entry_points loop below. For self-replace purposes, it's easier to model it as a replace rather than a delete + write. Do you think that's a problem?
There was a problem hiding this comment.
I think that's fine, though it'll change the error behavior. Perhaps we should defer errors until the end so we accomplish as many replacements as we can?
charliermarsh
force-pushed
the
charlie/self-tool
branch
from
0f1fbc1
to
51b02db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extending self-delete and self-replace functionality to uv itself on Windows.
Closes #6400.