Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor uv python install #8701

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Refactor uv python install #8701

merged 1 commit into from
Oct 30, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Oct 30, 2024

Pulling out of #8650 for readability.

Trying to clean this up to simplify extensions in the future. This is not a strict refactor, there are behavioral changes here.

  • Adds some structs for managing state.
  • Addresses some likely inconsistent behavior for weird edge-cases.
    • We fill platform information before checking if a request is satisfied.
    • We error earlier if we can't find a download for the request, i.e., even if you somehow have it installed.
    • Only reports versions as uninstalled if a download actually replaces them.
  • Moves some of the default output to tracing messages.
  • Even if an installation was already satisfied, we'll check that it is setup properly

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Oct 30, 2024
@zanieb zanieb marked this pull request as ready for review October 30, 2024 16:55
@zanieb zanieb enabled auto-merge (squash) October 30, 2024 21:26
@zanieb zanieb merged commit 893257b into main Oct 30, 2024
62 checks passed
@zanieb zanieb deleted the zb/refactor-inst branch October 30, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants