Resolve issues related to custom index URL and environment variables #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn fetch_env_credentials(&self, url: &Url) -> Option<Credentials> { | ||
| let host = url.host_str()?; | ||
| let index_name = host.replace('.', "_").to_uppercase(); | ||
| Credentials::from_env(&index_name) |
There was a problem hiding this comment.
I don't think this is quite right -- the index name is not necessarily the same as the URL host, it's a user-provided string.
There was a problem hiding this comment.
@charliermarsh ,
Can you help me by telling me the position of getting index_name by the url?
|
I think this was fixed separately by #8345 -- thanks for the PR, sorry for the overlap! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8324
Summary
I guess the
from_envfunction from the credentials was not set in the middleware. So, used in middleware.