Add support for reading and resolving include-group in dependency groups
#8266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
commented
Oct 16, 2024
zanieb
commented
Oct 16, 2024
zanieb
changed the title
include-group in dependency groupsinclude-group in dependency groups
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
e960e73
to
97f81d7
Compare
zanieb
force-pushed
the
zb/735-read-include
branch
from
4be3873
to
8bfbf37
Compare
| Table { | ||
| /// The name of the group to include | ||
| include_group: Option<String>, | ||
| }, |
There was a problem hiding this comment.
Do we... want a catch-all variant? So we can catch other objects that are added in the future...? (We might want to error in that case anyway.)
There was a problem hiding this comment.
I'm not sure. Sounds like a nice property sometimes? We don't do this elsewhere in the pyproject.toml do we?
There was a problem hiding this comment.
Ok the current structure is pretty strict... It rejects empty tables, extra fields, and missing include_group... It does match the reference implementation: https://peps.python.org/pep-0735/#reference-implementation. But I'd say what I have here is too strict though since we're doing eager validation. I think we should just warn if we see unsupported groups.
|
As discussed gonna take this one over, will push to this branch. |
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
97f81d7
to
946fbc0
Compare
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
946fbc0
to
f192195
Compare
zanieb
commented
Oct 16, 2024
zanieb
commented
Oct 16, 2024
zanieb
force-pushed
the
zb/735-sync-lock
branch
from
f192195
to
e4037bb
Compare
charliermarsh
force-pushed
the
zb/735-read-include
branch
3 times, most recently
from
02021d1
to
ab11585
Compare
charliermarsh
approved these changes
Oct 16, 2024
charliermarsh
force-pushed
the
zb/735-read-include
branch
from
ab11585
to
0a815bc
Compare
charliermarsh
force-pushed
the
zb/735-read-include
branch
from
0a815bc
to
ffe4c51
Compare
Merged
zanieb
added a commit
that referenced
this pull request
Oct 18, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
charliermarsh
added a commit
that referenced
this pull request
Oct 20, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
charliermarsh
added a commit
that referenced
this pull request
Oct 22, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
charliermarsh
added a commit
that referenced
this pull request
Oct 22, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
charliermarsh
added a commit
that referenced
this pull request
Oct 23, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
charliermarsh
added a commit
that referenced
this pull request
Oct 25, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
zanieb
added a commit
that referenced
this pull request
Oct 25, 2024
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8090
Adds the ability to read group inclusions (
include-group = <name>) in thepyproject.toml. Resolves groups into concrete dependencies for resolution.See #8110 for a bit more commentary on deferred work.