-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading and resolving include-group
in dependency groups
#8266
Conversation
include-group
in dependency groupsinclude-group
in dependency groups
e960e73
to
97f81d7
Compare
4be3873
to
8bfbf37
Compare
Table { | ||
/// The name of the group to include | ||
include_group: Option<String>, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we... want a catch-all variant? So we can catch other objects that are added in the future...? (We might want to error in that case anyway.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. Sounds like a nice property sometimes? We don't do this elsewhere in the pyproject.toml
do we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok the current structure is pretty strict... It rejects empty tables, extra fields, and missing include_group
... It does match the reference implementation: https://peps.python.org/pep-0735/#reference-implementation. But I'd say what I have here is too strict though since we're doing eager validation. I think we should just warn if we see unsupported groups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me.
As discussed gonna take this one over, will push to this branch. |
97f81d7
to
946fbc0
Compare
946fbc0
to
f192195
Compare
f192195
to
e4037bb
Compare
02021d1
to
ab11585
Compare
ab11585
to
0a815bc
Compare
0a815bc
to
ffe4c51
Compare
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
…roups (#8266) Part of #8090 Adds the ability to read group inclusions (`include-group = <name>`) in the `pyproject.toml`. Resolves groups into concrete dependencies for resolution. See #8110 for a bit more commentary on deferred work. --------- Co-authored-by: Charlie Marsh <[email protected]>
Part of #8090
Adds the ability to read group inclusions (
include-group = <name>
) in thepyproject.toml
. Resolves groups into concrete dependencies for resolution.See #8110 for a bit more commentary on deferred work.