Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when trying to
uv sync
a package without build configuration #7420Warn when trying to
uv sync
a package without build configuration #7420Changes from 2 commits
4cf007d
2e976e7
9e410d7
ad900be
5161c52
76b2956
591e4a6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be surprised if we needed this exact combination again. I'd just add a function like
has_scripts
and&&
that withis_package
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note:
IgnoredAny
doesn't implementEq
, but the trait here seemed unused and fine to drop. Alternatively, we can either 1) store TOML tables in here, or 2) fully deserialize both scripts fields.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: sync is performed on CLI add/remove/sync/run, but it seems to annoying to warn on each command. Thus this new warning is only displayed at
uv run
time, which should be the most effective place. But can be expanded if we prefer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to omit at
add
/remove
. We might want it atsync
, otherwise if you sync then active the environment (instead of usinguv run
), you'll never see it.Maybe with some special-casing per https://github.com/astral-sh/uv/pull/7420/files#r1761054908 we can make the warnings quieter in
uv run
.