Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect musl and error for musl pbs builds #6643

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Commits on Aug 26, 2024

  1. Detect musl and error for musl pbs builds

    As described in #4242, we're currently incorrectly downloading glibc python-build-standalone on musl target, but we also can't fix this by using musl python-build-standalone on musl targets since the musl builds are effectively broken.
    
    We reintroduce the libc detection previously removed in #2381, using it to detect which libc is the current one.
    
    For simplicity, i've decided to just filter out the musl python-build-standalone archives from the list of available archive, given this is temporary. This means we show the same error message as if we don't have a build for the platform. We could also add a dedicated error message for musl.
    
    Fixes #4242
    
    ## Test strategy
    
    On my ubuntu host, python downloads continue to pass:
    ```
    target/x86_64-unknown-linux-musl/debug/uv python install
    ```
    
    On alpine, we fail:
    ```
    $ docker run -it --rm -v .:/io alpine /io/target/x86_64-unknown-linux-musl/debug/uv python install
      Searching for Python installations
      error: No download found for request: cpython-any-linux-x86_64-musl
    ```
    konstin committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    23f2894 View commit details
    Browse the repository at this point in the history
  2. lint

    konstin committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    515fec7 View commit details
    Browse the repository at this point in the history
  3. Support empty PATH

    konstin committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    4b5dd08 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Add docs

    charliermarsh committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    cb818f9 View commit details
    Browse the repository at this point in the history