Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bias towards local directories for bare editable requirements #3995

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Given install -e dagster, we need to assume that the user meant install -e ./dagster, even though install dagster should not be treated as install ./dagster. I suspect pip will change this in the future (since pip install dagster does not meant pip install ./dagster) but for now it's what users expect.

Closes #3994.

@charliermarsh charliermarsh added the bug Something isn't working label Jun 3, 2024
@charliermarsh charliermarsh marked this pull request as ready for review June 3, 2024 19:23
@charliermarsh
Copy link
Member Author

Needs tests.

Copy link

codspeed-hq bot commented Jun 3, 2024

CodSpeed Performance Report

Merging #3995 will not alter performance

Comparing charlie/pref (787920a) with main (420333a)

Summary

✅ 13 untouched benchmarks

@konstin
Copy link
Member

konstin commented Jun 4, 2024

Is there a pip issue to subscribe to?

@charliermarsh
Copy link
Member Author

I only see pypa/pip#1289 (comment) where they mention that lack of PEP 508 support for editables is an implementation issue, not a design issue. But if they change editables to support PEP 508, I think they'll have the same behavior as us (prior to this PR), unless they also special-case it?

@charliermarsh
Copy link
Member Author

I asked in pip here: pypa/pip#12745

@charliermarsh charliermarsh force-pushed the charlie/pref branch 2 times, most recently from 3814987 to 3e6654d Compare June 4, 2024 19:28
@charliermarsh charliermarsh enabled auto-merge (squash) June 4, 2024 19:29
@charliermarsh charliermarsh merged commit 8eea470 into main Jun 4, 2024
46 checks passed
@charliermarsh charliermarsh deleted the charlie/pref branch June 4, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv 0.2.6 broke editable installs in a local folder
3 participants